Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/browser/resources/options/browser_options.html

Issue 2016073004: Show a visual indicator for the progress of auto-click. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Used a timedelta in autoclick controller instead of int. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« chrome/browser/chromeos/ui/autoclick_ring_handler.cc ('K') | « chrome/browser/chromeos/ui/autoclick_ring_handler.cc ('k') | chrome/browser/ui/ash/ash_init.cc » ('j') | chrome/browser/ui/ash/ash_init.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <div id="settings" class="page" hidden> 1 <div id="settings" class="page" hidden>
2 <header> 2 <header>
3 <h1 i18n-content="settingsTitle"></h1> 3 <h1 i18n-content="settingsTitle"></h1>
4 </header> 4 </header>
5 <include src="automatic_settings_reset_banner.html"> 5 <include src="automatic_settings_reset_banner.html">
6 <if expr="chromeos"> 6 <if expr="chromeos">
7 <link rel="import" href="chrome://resources/cr_elements/network/cr_network_ico n.html"> 7 <link rel="import" href="chrome://resources/cr_elements/network/cr_network_ico n.html">
8 <link rel="import" href="chrome://resources/cr_elements/network/cr_onc_types.h tml"> 8 <link rel="import" href="chrome://resources/cr_elements/network/cr_onc_types.h tml">
9 <include src="secondary_user_banner.html"> 9 <include src="secondary_user_banner.html">
10 <section id="network-section-cros"> 10 <section id="network-section-cros">
(...skipping 937 matching lines...) Expand 10 before | Expand all | Expand 10 after
948 </div> 948 </div>
949 <div class="checkbox"> 949 <div class="checkbox">
950 <!-- No whitespace between elements. --> 950 <!-- No whitespace between elements. -->
951 <input type="checkbox" class="spacer-checkbox"><span 951 <input type="checkbox" class="spacer-checkbox"><span
952 id="accessibility-autoclick-label" 952 id="accessibility-autoclick-label"
953 i18n-content="accessibilityAutoclickDropdown"> 953 i18n-content="accessibilityAutoclickDropdown">
954 </span><select id="accessibility-autoclick-dropdown" class="control" 954 </span><select id="accessibility-autoclick-dropdown" class="control"
955 data-type="number" 955 data-type="number"
956 aria-labelledby="accessibility-autoclick-label" 956 aria-labelledby="accessibility-autoclick-label"
957 pref="settings.a11y.autoclick_delay_ms"> 957 pref="settings.a11y.autoclick_delay_ms">
958 <option value="200" 958 <!-- 18n strings contain the autoclick duration; if the autoclick
jdufault 2016/06/09 16:41:26 Missing the i in i18n
sammiequon 2016/06/10 19:30:26 Done.
959 timing gets changed, then the 18n strings also
960 need to be updated. -->
961 <option value="600"
959 i18n-content="autoclickDelayExtremelyShort"></option> 962 i18n-content="autoclickDelayExtremelyShort"></option>
960 <option value="400" 963 <option value="800"
961 i18n-content="autoclickDelayVeryShort"></option> 964 i18n-content="autoclickDelayVeryShort"></option>
962 <option value="600" i18n-content="autoclickDelayShort"> 965 <option value="1000" i18n-content="autoclickDelayShort">
963 </option> 966 </option>
964 <option value="800" i18n-content="autoclickDelayLong"> 967 <option value="2000" i18n-content="autoclickDelayLong">
965 </option> 968 </option>
966 <option value="1000" 969 <option value="4000"
967 i18n-content="autoclickDelayVeryLong"></option> 970 i18n-content="autoclickDelayVeryLong"></option>
968 </select> 971 </select>
969 <span class="controlled-setting-indicator" 972 <span class="controlled-setting-indicator"
970 pref="settings.a11y.autoclick_delay_ms"></span> 973 pref="settings.a11y.autoclick_delay_ms"></span>
971 </div> 974 </div>
972 </div> 975 </div>
973 <div class="option-name" id="accessibility_onscreen_keyboard"> 976 <div class="option-name" id="accessibility_onscreen_keyboard">
974 <div class="checkbox controlled-setting-with-label"> 977 <div class="checkbox controlled-setting-with-label">
975 <label> 978 <label>
976 <input pref="settings.a11y.virtual_keyboard" type="checkbox" 979 <input pref="settings.a11y.virtual_keyboard" type="checkbox"
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
1120 </button> 1123 </button>
1121 </div> 1124 </div>
1122 </section> 1125 </section>
1123 </div> <!-- advanced-settings-container --> 1126 </div> <!-- advanced-settings-container -->
1124 </div> <!-- advanced-settings --> 1127 </div> <!-- advanced-settings -->
1125 <footer id="advanced-settings-footer"> 1128 <footer id="advanced-settings-footer">
1126 <a is="action-link" id="advanced-settings-expander" 1129 <a is="action-link" id="advanced-settings-expander"
1127 i18n-content="showAdvancedSettings"></a> 1130 i18n-content="showAdvancedSettings"></a>
1128 </footer> 1131 </footer>
1129 </div> 1132 </div>
OLDNEW
« chrome/browser/chromeos/ui/autoclick_ring_handler.cc ('K') | « chrome/browser/chromeos/ui/autoclick_ring_handler.cc ('k') | chrome/browser/ui/ash/ash_init.cc » ('j') | chrome/browser/ui/ash/ash_init.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698