ash/autoclick/autoclickgesture_delegate.h - Issue 2016073004: Show a visual indicator for the progress of auto-click.

Side by Side Diff: ash/autoclick/autoclickgesture_delegate.h

Issue 2016073004: Show a visual indicator for the progress of auto-click. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Moved ring rendering code to chrome/browser/chromeos/ui Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
	jdufault 2016/06/03 22:02:44 What about defining this class inside of Autoclick What about defining this class inside of AutoclickController, such that it is externally accessible as AutoclickController::Delegate sammiequon 2016/06/07 18:06:16 Done. Show quoted text On 2016/06/03 22:02:44, jdufault wrote: > What about defining this class inside of AutoclickController, such that it is > externally accessible as > > AutoclickController::Delegate Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef ASH_AUTOCLICKGESTURE_DELEGATE_H_

	6 #define ASH_AUTOCLICKGESTURE_DELEGATE_H_

	7

	8 #include "ui/gfx/geometry/point.h"

	9

	10 namespace ash {

	11

	12 // Delegate for taking screenshots.

	13 class AutoclickgestureDelegate {
	jdufault 2016/06/03 22:02:44 gesture should be capitalized to Gesture, so Autoc gesture should be capitalized to Gesture, so AutoclickGestureDelegate. Then rename the file to autoclick_gesture_delegate.h
	14 public:

	15 virtual ~AutoclickgestureDelegate() {}

	16

	17 // The actual task of starting the display of a gesture.
	jdufault 2016/06/03 22:02:44 How about comments like: Called when an autocli How about comments like: Called when an autoclick gesture begins. Called when the autoclick gesture has ended, either because the mouse moved or because the autoclick completed. The delegate doesn't have to be related to the display of the gesture; for example, it could be used in a test. sammiequon 2016/06/07 18:06:16 Done. Show quoted text On 2016/06/03 22:02:44, jdufault wrote: > How about comments like: > > Called when an autoclick gesture begins. > > Called when the autoclick gesture has ended, either because the mouse moved or > because the autoclick completed. > > The delegate doesn't have to be related to the display of the gesture; for > example, it could be used in a test. Done. sammiequon 2016/06/07 18:06:16 Done. Show quoted text On 2016/06/03 22:02:44, jdufault wrote: > How about comments like: > > Called when an autoclick gesture begins. > > Called when the autoclick gesture has ended, either because the mouse moved or > because the autoclick completed. > > The delegate doesn't have to be related to the display of the gesture; for > example, it could be used in a test. Done.
	18 virtual void StartGesture(int delay_ms, gfx::Point center) = 0;

	19

	20 // The actual task of stopping a gesture from being displayed.

	21 virtual void StopGesture() = 0;

	22

	23 virtual void SetGestureCenter(gfx::Point center) = 0;
	jdufault 2016/06/03 22:02:44 Add DISALLOW_COPY_AND_ASSIGN(AutoclickgestureDeleg Add DISALLOW_COPY_AND_ASSIGN(AutoclickgestureDelegate) to the end of this class. jdufault 2016/06/03 22:02:44 Please add a comment to SetGestureCenter. Please add a comment to SetGestureCenter. sammiequon 2016/06/07 18:06:16 Done. Show quoted text On 2016/06/03 22:02:44, jdufault wrote: > Add DISALLOW_COPY_AND_ASSIGN(AutoclickgestureDelegate) to the end of this class. Done.
	24 };

	25 } // namespace ash

	26

	27 #endif // ASH_AUTOCLICKGESTURE_DELEGATE_H_

OLD	NEW