content/renderer/media/media_interface_provider.cc - Issue 2016053003: Add audio_device_id in mojo media ServiceFactory CreateRenderer api.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_interface_provider.cc

Issue 2016053003: Add audio_device_id in mojo media ServiceFactory CreateRenderer api. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Fix compile error Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chromecast/browser/media/cast_mojo_media_client.cc ('k') | media/mojo/interfaces/service_factory.mojom » ('j') | media/mojo/services/media_mojo_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/media_interface_provider.cc

diff --git a/content/renderer/media/media_interface_provider.cc b/content/renderer/media/media_interface_provider.cc

index 8e3968e2182dc0f0c44ab401a1b891c7e04c5d21..e1052421ad7a27666dd564dc57c28cc5a53e3d53 100644

--- a/content/renderer/media/media_interface_provider.cc

+++ b/content/renderer/media/media_interface_provider.cc

@@ -33,7 +33,7 @@ void MediaInterfaceProvider::GetInterface(const mojo::String& interface_name,

std::move(pipe)));

} else if (interface_name == media::mojom::Renderer::Name_) {

GetMediaServiceFactory()->CreateRenderer(

- mojo::MakeRequest<media::mojom::Renderer>(std::move(pipe)));

+ mojo::MakeRequest<media::mojom::Renderer>(std::move(pipe)), "");

alokp 2016/06/02 04:47:55 since string is optional, may be we should pass a

tianyuwang1 2016/06/02 05:18:39 Done.

} else if (interface_name == media::mojom::AudioDecoder::Name_) {

GetMediaServiceFactory()->CreateAudioDecoder(

mojo::MakeRequest<media::mojom::AudioDecoder>(std::move(pipe)));