Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: media/mojo/services/service_factory_impl.cc

Issue 2016053003: Add audio_device_id in mojo media ServiceFactory CreateRenderer api. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Change all places that uses CreateRenderer api to pass in a device_id. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/mojo/services/service_factory_impl.h" 5 #include "media/mojo/services/service_factory_impl.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/message_loop/message_loop.h" 8 #include "base/message_loop/message_loop.h"
9 #include "media/audio/audio_device_description.h"
9 #include "media/base/media_log.h" 10 #include "media/base/media_log.h"
10 #include "media/mojo/services/mojo_media_client.h" 11 #include "media/mojo/services/mojo_media_client.h"
11 #include "services/shell/public/interfaces/interface_provider.mojom.h" 12 #include "services/shell/public/interfaces/interface_provider.mojom.h"
12 13
13 #if defined(ENABLE_MOJO_AUDIO_DECODER) 14 #if defined(ENABLE_MOJO_AUDIO_DECODER)
14 #include "media/mojo/services/mojo_audio_decoder_service.h" 15 #include "media/mojo/services/mojo_audio_decoder_service.h"
15 #endif // defined(ENABLE_MOJO_AUDIO_DECODER) 16 #endif // defined(ENABLE_MOJO_AUDIO_DECODER)
16 17
17 #if defined(ENABLE_MOJO_VIDEO_DECODER) 18 #if defined(ENABLE_MOJO_VIDEO_DECODER)
18 #include "media/mojo/services/mojo_video_decoder_service.h" 19 #include "media/mojo/services/mojo_video_decoder_service.h"
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 } 75 }
75 76
76 void ServiceFactoryImpl::CreateVideoDecoder( 77 void ServiceFactoryImpl::CreateVideoDecoder(
77 mojom::VideoDecoderRequest request) { 78 mojom::VideoDecoderRequest request) {
78 #if defined(ENABLE_MOJO_VIDEO_DECODER) 79 #if defined(ENABLE_MOJO_VIDEO_DECODER)
79 new MojoVideoDecoderService(std::move(request), mojo_media_client_); 80 new MojoVideoDecoderService(std::move(request), mojo_media_client_);
80 #endif // defined(ENABLE_MOJO_VIDEO_DECODER) 81 #endif // defined(ENABLE_MOJO_VIDEO_DECODER)
81 } 82 }
82 83
83 void ServiceFactoryImpl::CreateRenderer( 84 void ServiceFactoryImpl::CreateRenderer(
84 mojo::InterfaceRequest<mojom::Renderer> request) { 85 mojo::InterfaceRequest<mojom::Renderer> request,
86 const mojo::String& audio_device_id) {
85 #if defined(ENABLE_MOJO_RENDERER) 87 #if defined(ENABLE_MOJO_RENDERER)
86 // The created object is owned by the pipe. 88 // The created object is owned by the pipe.
87 // The audio and video sinks are owned by the client. 89 // The audio and video sinks are owned by the client.
90 std::string device_id = audio_device_id.get();
91 if (audio_device_id.is_null())
92 device_id = AudioDeviceDescription::kDefaultDeviceId;
93
94 AudioRendererSink* audio_renderer_sink =
95 mojo_media_client_->CreateAudioRendererSink(device_id);
96
88 scoped_refptr<base::SingleThreadTaskRunner> task_runner( 97 scoped_refptr<base::SingleThreadTaskRunner> task_runner(
89 base::MessageLoop::current()->task_runner()); 98 base::MessageLoop::current()->task_runner());
90 AudioRendererSink* audio_renderer_sink =
91 mojo_media_client_->CreateAudioRendererSink();
92 VideoRendererSink* video_renderer_sink = 99 VideoRendererSink* video_renderer_sink =
93 mojo_media_client_->CreateVideoRendererSink(task_runner); 100 mojo_media_client_->CreateVideoRendererSink(task_runner);
94 101
95 RendererFactory* renderer_factory = GetRendererFactory(); 102 RendererFactory* renderer_factory = GetRendererFactory();
96 if (!renderer_factory) 103 if (!renderer_factory)
97 return; 104 return;
98 105
99 std::unique_ptr<Renderer> renderer = renderer_factory->CreateRenderer( 106 std::unique_ptr<Renderer> renderer = renderer_factory->CreateRenderer(
100 task_runner, task_runner, audio_renderer_sink, video_renderer_sink, 107 task_runner, task_runner, audio_renderer_sink, video_renderer_sink,
101 RequestSurfaceCB()); 108 RequestSurfaceCB());
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 CdmFactory* ServiceFactoryImpl::GetCdmFactory() { 143 CdmFactory* ServiceFactoryImpl::GetCdmFactory() {
137 if (!cdm_factory_) { 144 if (!cdm_factory_) {
138 cdm_factory_ = mojo_media_client_->CreateCdmFactory(interfaces_); 145 cdm_factory_ = mojo_media_client_->CreateCdmFactory(interfaces_);
139 LOG_IF(ERROR, !cdm_factory_) << "CdmFactory not available."; 146 LOG_IF(ERROR, !cdm_factory_) << "CdmFactory not available.";
140 } 147 }
141 return cdm_factory_.get(); 148 return cdm_factory_.get();
142 } 149 }
143 #endif // defined(ENABLE_MOJO_CDM) 150 #endif // defined(ENABLE_MOJO_CDM)
144 151
145 } // namespace media 152 } // namespace media
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698