OLD | NEW |
---|---|
1 // Copyright 2014 The Chromium Authors. All rights reserved. | 1 // Copyright 2014 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #ifndef MEDIA_MOJO_SERVICES_MOJO_MEDIA_CLIENT_H_ | 5 #ifndef MEDIA_MOJO_SERVICES_MOJO_MEDIA_CLIENT_H_ |
6 #define MEDIA_MOJO_SERVICES_MOJO_MEDIA_CLIENT_H_ | 6 #define MEDIA_MOJO_SERVICES_MOJO_MEDIA_CLIENT_H_ |
7 | 7 |
8 #include <memory> | 8 #include <memory> |
9 | 9 |
10 #include "base/memory/ref_counted.h" | 10 #include "base/memory/ref_counted.h" |
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
45 virtual std::unique_ptr<AudioDecoder> CreateAudioDecoder( | 45 virtual std::unique_ptr<AudioDecoder> CreateAudioDecoder( |
46 scoped_refptr<base::SingleThreadTaskRunner> task_runner); | 46 scoped_refptr<base::SingleThreadTaskRunner> task_runner); |
47 | 47 |
48 virtual std::unique_ptr<VideoDecoder> CreateVideoDecoder( | 48 virtual std::unique_ptr<VideoDecoder> CreateVideoDecoder( |
49 scoped_refptr<base::SingleThreadTaskRunner> task_runner); | 49 scoped_refptr<base::SingleThreadTaskRunner> task_runner); |
50 | 50 |
51 // TODO(xhwang): Consider creating Renderer and CDM directly in the client | 51 // TODO(xhwang): Consider creating Renderer and CDM directly in the client |
52 // instead of creating factories. See http://crbug.com/586211 | 52 // instead of creating factories. See http://crbug.com/586211 |
53 | 53 |
54 // Returns the RendererFactory to be used by MojoRendererService. | 54 // Returns the RendererFactory to be used by MojoRendererService. |
55 virtual std::unique_ptr<RendererFactory> CreateRendererFactory( | 55 virtual std::unique_ptr<RendererFactory> CreateRendererFactory( |
alokp
2016/06/01 00:06:14
I think we would need to change this API to accept
xhwang
2016/06/01 05:26:27
I agree it seems the time to address the comment/T
tianyuwang1
2016/06/02 03:32:32
Done. Added CreateRender api. Removed CreateRend
| |
56 const scoped_refptr<MediaLog>& media_log); | 56 const scoped_refptr<MediaLog>& media_log); |
57 | 57 |
58 // The output sink used for rendering audio or video respectively. They will | 58 // The output sink used for rendering audio or video respectively. They will |
59 // be used in the CreateRenderer() call on the RendererFactory returned by | 59 // be used in the CreateRenderer() call on the RendererFactory returned by |
60 // CreateRendererFactory(). May be null if the RendererFactory doesn't need an | 60 // CreateRendererFactory(). May be null if the RendererFactory doesn't need an |
61 // audio or video sink. If not null, the sink must be owned by the client. | 61 // audio or video sink. If not null, the sink must be owned by the client. |
62 virtual AudioRendererSink* CreateAudioRendererSink(); | 62 virtual AudioRendererSink* CreateAudioRendererSink( |
63 const std::string& device_id); | |
63 virtual VideoRendererSink* CreateVideoRendererSink( | 64 virtual VideoRendererSink* CreateVideoRendererSink( |
64 const scoped_refptr<base::SingleThreadTaskRunner>& task_runner); | 65 const scoped_refptr<base::SingleThreadTaskRunner>& task_runner); |
65 | 66 |
66 // Returns the CdmFactory to be used by MojoCdmService. | 67 // Returns the CdmFactory to be used by MojoCdmService. |
67 virtual std::unique_ptr<CdmFactory> CreateCdmFactory( | 68 virtual std::unique_ptr<CdmFactory> CreateCdmFactory( |
68 shell::mojom::InterfaceProvider* interface_provider); | 69 shell::mojom::InterfaceProvider* interface_provider); |
69 | 70 |
70 protected: | 71 protected: |
71 MojoMediaClient(); | 72 MojoMediaClient(); |
72 }; | 73 }; |
73 | 74 |
74 } // namespace media | 75 } // namespace media |
75 | 76 |
76 #endif // MEDIA_MOJO_SERVICES_MOJO_MEDIA_CLIENT_H_ | 77 #endif // MEDIA_MOJO_SERVICES_MOJO_MEDIA_CLIENT_H_ |
OLD | NEW |