third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.h - Issue 2016043002: Avoid copy pixel data in texImage2D(ImageBitmap)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.h

Issue 2016043002: Avoid copy pixel data in texImage2D(ImageBitmap) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: change to OwnPtr Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/ImageBitmap.cpp ('K') | « third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp ('k') | third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.h

diff --git a/third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.h b/third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.h

index 8815e8ed9f2a2f83f380e4811334ef6eb93fe785..c961c7d2209e9f9af3af35206c84350327dc5b8c 100644

--- a/third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.h

+++ b/third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.h

@@ -193,7 +193,7 @@ public:

// packing the pixel data according to the given format and type,

// and obeying the flipY and premultiplyAlpha flags. Returns true

// upon success.

- static bool extractImageData(const uint8_t*, const IntSize&, GLenum format, GLenum type, bool flipY, bool premultiplyAlpha, Vector<uint8_t>& data);

+ static bool extractImageData(const uint8_t*, DataFormat sourceDataFormat, const IntSize&, GLenum format, GLenum type, bool flipY, bool premultiplyAlpha, Vector<uint8_t>& data);

// Helper function which extracts the user-supplied texture

// data, applying the flipY and premultiplyAlpha parameters.