Resynthesize ParameterElementImpl.parameterKind lazily.

Resynthesize ParameterElementImpl.parameterKind lazily.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/cdc0b172464791d57d2ce9fd10049b98fadab79a

[Brian Wilkerson, 2016-05-26 16:50:07]

I suppose it lgtm, but I have to wonder

(1) Is it worth it? Seems like such a small amount of work to do when reading
the summary that making it lazy doesn't seem like a win. But I assume you
wouldn't be doing it if it weren't.

(2) Couldn't we just parse the ParameterKind directly when reading from the flat
buffer rather than creating an UnlinkedParamKind and then converting it? Seems
like it would be more efficient.

[scheglov, 2016-05-26 17:05:30]

On 2016/05/26 16:50:07, Brian Wilkerson wrote:
> I suppose it lgtm, but I have to wonder
> 
> (1) Is it worth it? Seems like such a small amount of work to do when reading
> the summary that making it lazy doesn't seem like a win. But I assume you
> wouldn't be doing it if it weren't.
> 
> (2) Couldn't we just parse the ParameterKind directly when reading from the
flat
> buffer rather than creating an UnlinkedParamKind and then converting it? Seems
> like it would be more efficient.

From performance point of view it does not make much sense to resynthesize
parameterKind lazily.
There is some saving in this, because we avoid reading from flat buffer at all
it kind is not asked, but only potential and probably very small.
But what is more important is that the ultimate goal is to resynthesize
everything lazily.

For now none of the enums which we use in flat buffers are a visible in
profiler.
So, for now we can keep them as a nicer interface.

[scheglov, 2016-05-26 17:08:53]

Description was changed from

==========
Resynthesize ParameterElementImpl.parameterKind lazily.

R=brianwilkerson@google.com
BUG=
==========

to

==========
Resynthesize ParameterElementImpl.parameterKind lazily.

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/cdc0b172464791d57d2ce9fd10049b98fadab79a
==========

[scheglov, 2016-05-26 17:08:54]

Committed patchset #1 (id:1) manually as
cdc0b172464791d57d2ce9fd10049b98fadab79a (presubmit successful).