Issue 201593004: Stage ES6 promises and weak collections

Issue 201593004: Stage ES6 promises and weak collections (Closed)

Created:
6 years, 9 months ago by rossberg

Modified:
6 years, 9 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Stage ES6 promises and weak collections Split collections flag into weak and non-weak. R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20019

Patch Set 2 : Move regression tests as well #

Patch Set 3 : Added lost weak_collections test (and rebased) #

Total comments: 2

Patch Set 4 : Comment #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -1511 lines)			Patch
M	src/bootstrapper.cc	View		2 chunks	+8 lines, -4 lines	0 comments	Download
M	src/collection.js	View		2 chunks	+0 lines, -173 lines	0 comments	Download
M	src/flag-definitions.h	View		3 chunks	+7 lines, -3 lines	0 comments	Download
A +	src/weak_collection.js	View		1 chunk	+0 lines, -197 lines	0 comments	Download
A +	test/mjsunit/es6/promises.js	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	test/mjsunit/es6/regress/regress-2034.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A +	test/mjsunit/es6/regress/regress-2156.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A +	test/mjsunit/es6/regress/regress-2829.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A +	test/mjsunit/es6/weak_collections.js	View	1 2 3	16 chunks	+20 lines, -195 lines	0 comments	Download
M	test/mjsunit/es7/object-observe.js	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	test/mjsunit/harmony/collections.js	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	test/mjsunit/harmony/private.js	View		1 chunk	+1 line, -1 line	0 comments	Download
D	test/mjsunit/harmony/promises.js	View		1 chunk	+0 lines, -791 lines	0 comments	Download
M	test/mjsunit/harmony/proxies-hash.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/harmony/regress/regress-2034.js	View	1	1 chunk	+0 lines, -46 lines	0 comments	Download
M	test/mjsunit/harmony/regress/regress-2156.js	View	1	1 chunk	+0 lines, -39 lines	0 comments	Download
M	test/mjsunit/harmony/regress/regress-2829.js	View	1	1 chunk	+0 lines, -53 lines	0 comments	Download
M	test/mjsunit/harmony/symbols.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/regress/regress-crbug-350864.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/gyp/v8.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

Still LGTM, just a nit. https://codereview.chromium.org/201593004/diff/40001/test/mjsunit/es6/weak_collections.js File test/mjsunit/es6/weak_collections.js (right): https://codereview.chromium.org/201593004/diff/40001/test/mjsunit/es6/weak_collections.js#newcode41 test/mjsunit/es6/weak_collections.js:41: print(WeakSet); nit: Let's drop ...

6 years, 9 months ago (2014-03-18 09:54:26 UTC) #3

rossberg

https://codereview.chromium.org/201593004/diff/40001/test/mjsunit/es6/weak_collections.js File test/mjsunit/es6/weak_collections.js (right): https://codereview.chromium.org/201593004/diff/40001/test/mjsunit/es6/weak_collections.js#newcode41 test/mjsunit/es6/weak_collections.js:41: print(WeakSet); On 2014/03/18 09:54:26, Michael Starzinger wrote: > nit: ...

6 years, 9 months ago (2014-03-18 09:57:24 UTC) #4

rossberg

6 years, 9 months ago (2014-03-18 09:57:33 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 manually as r20019 (presubmit successful).

Expand Messages | Collapse Messages