Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 201593002: Add WebSerializedOrigin to represent a serialized Web Origin. (Closed)

Created:
6 years, 9 months ago by yhirano
Modified:
6 years, 9 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add WebSerializedOrigin to represent a serialized Web Origin. Use it in WebSocket. BUG=339373 R=tyoshino, abarth Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169591

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -5 lines) Patch
M Source/modules/websockets/NewWebSocketChannelImpl.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/blink_platform.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A Source/platform/exported/WebSerializedOrigin.cpp View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
A public/platform/WebSerializedOrigin.h View 1 2 3 1 chunk +40 lines, -0 lines 0 comments Download
M public/platform/WebSocketHandle.h View 1 2 2 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
yhirano
6 years, 9 months ago (2014-03-19 04:30:50 UTC) #1
tyoshino (SeeGerritForStatus)
lgtm https://codereview.chromium.org/201593002/diff/40001/Source/platform/exported/WebSerializedOrigin.cpp File Source/platform/exported/WebSerializedOrigin.cpp (right): https://codereview.chromium.org/201593002/diff/40001/Source/platform/exported/WebSerializedOrigin.cpp#newcode30 Source/platform/exported/WebSerializedOrigin.cpp:30: // OF THIS SOFTWARE, EVEN IF ADVISED OF ...
6 years, 9 months ago (2014-03-19 05:43:11 UTC) #2
yhirano
https://codereview.chromium.org/201593002/diff/40001/Source/platform/exported/WebSerializedOrigin.cpp File Source/platform/exported/WebSerializedOrigin.cpp (right): https://codereview.chromium.org/201593002/diff/40001/Source/platform/exported/WebSerializedOrigin.cpp#newcode30 Source/platform/exported/WebSerializedOrigin.cpp:30: // OF THIS SOFTWARE, EVEN IF ADVISED OF THE ...
6 years, 9 months ago (2014-03-19 06:36:15 UTC) #3
yhirano
+abarth for public/platform and Source/platform.
6 years, 9 months ago (2014-03-19 06:37:05 UTC) #4
abarth-chromium
LGTM! Thanks! There are a bunch of places in the storage systems where we should ...
6 years, 9 months ago (2014-03-19 17:09:44 UTC) #5
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 9 months ago (2014-03-19 17:09:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/201593002/60001
6 years, 9 months ago (2014-03-19 17:09:51 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 17:12:55 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-19 17:12:59 UTC) #9
yhirano
The CQ bit was checked by yhirano@chromium.org
6 years, 9 months ago (2014-03-19 23:01:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/201593002/60001
6 years, 9 months ago (2014-03-19 23:01:28 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 23:30:41 UTC) #12
Message was sent while issue was closed. 
Change committed as 169591

Powered by Google App Engine
This is Rietveld 408576698