Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2015923003: Reland of Add logic to ResourceProvider to correctly lock GpuMemoryBuffer Resources. (Closed)

Created:
4 years, 7 months ago by ccameron
Modified:
4 years, 7 months ago
Reviewers:
erikchen
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Add logic to ResourceProvider to correctly lock GpuMemoryBuffer Resources. (patchset #1 id:1 of https://codereview.chromium.org/2006153002/ ) Reason for revert: The patch that this depended on, https://codereview.chromium.org/1993333002/, has landed. Original issue's description: > Revert of Add logic to ResourceProvider to correctly lock GpuMemoryBuffer Resources. (patchset #8 id:140001 of https://codereview.chromium.org/1984873002/ ) > > Reason for revert: > Depending on an implementation still in review. Results in flooding of LOG messages. > > https://bugs.chromium.org/p/chromium/issues/detail?id=614155 > https://codereview.chromium.org/1993333002/ > > Original issue's description: > > Add logic to ResourceProvider to correctly lock GpuMemoryBuffer Resources. > > > > The new logic will hold onto GpuMemoryBuffer Resources until they are no longer > > in use by the Window Server. > > > > BUG=608026 > > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > > > Committed: https://crrev.com/87aa976eacd8ed0c530d32a7c85d6ba706dcabf6 > > Cr-Commit-Position: refs/heads/master@{#395150} > > TBR=ccameron@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=608026 > > Committed: https://crrev.com/aa5126ff66379a9060e87b010135f1aee7fc1ab2 > Cr-Commit-Position: refs/heads/master@{#395524} TBR=erikchen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=608026 Committed: https://crrev.com/f8a942fbb35c30edcc88cfe859ceda7b469096af Cr-Commit-Position: refs/heads/master@{#396233}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -17 lines) Patch
M cc/output/gl_renderer.h View 1 chunk +12 lines, -3 lines 0 comments Download
M cc/output/gl_renderer.cc View 4 chunks +41 lines, -14 lines 0 comments Download
M cc/resources/resource_provider.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/resources/resource_provider.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
ccameron
Created Reland of Add logic to ResourceProvider to correctly lock GpuMemoryBuffer Resources.
4 years, 7 months ago (2016-05-26 17:25:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015923003/1
4 years, 7 months ago (2016-05-26 17:25:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015923003/1
4 years, 7 months ago (2016-05-26 17:31:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015923003/1
4 years, 7 months ago (2016-05-26 18:01:39 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-26 18:24:23 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 18:25:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f8a942fbb35c30edcc88cfe859ceda7b469096af
Cr-Commit-Position: refs/heads/master@{#396233}

Powered by Google App Engine
This is Rietveld 408576698