tests/compiler/dart2js/serialization/equivalence_test.dart - Issue 2015903002: Compute and check members for serialization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/serialization/equivalence_test.dart

Issue 2015903002: Compute and check members for serialization (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Fix invariant Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/resolution/class_members.dart ('K') | « pkg/compiler/lib/src/serialization/equivalence.dart ('k') | tests/compiler/dart2js/serialization/members_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/compiler/dart2js/serialization/equivalence_test.dart

diff --git a/tests/compiler/dart2js/serialization/equivalence_test.dart b/tests/compiler/dart2js/serialization/equivalence_test.dart

index f6ca1d3380533dfc03af1754235f0852cb925d92..ec4d53de53e7c2f67bf4062e16dc20020bd4ae03 100644

--- a/tests/compiler/dart2js/serialization/equivalence_test.dart

+++ b/tests/compiler/dart2js/serialization/equivalence_test.dart

@@ -384,7 +384,7 @@ class ElementPropertyEquivalence extends BaseElementVisitor<dynamic, Element> {

void visitClassElement(ClassElement element1, ClassElement element2) {

checkElementIdentities(null, null, null, element1, element2);

check(element1, element2, 'name',

- element1.name, element2.name);

+ element1.name, element2.name);

if (!element1.isUnnamedMixinApplication) {

check(element1, element2, 'sourcePosition',

element1.sourcePosition, element2.sourcePosition);

@@ -427,27 +427,27 @@ class ElementPropertyEquivalence extends BaseElementVisitor<dynamic, Element> {

EnumClassElement enum1 = element1;

EnumClassElement enum2 = element2;

checkElementLists(enum1, enum2, 'enumValues',

- enum1.enumValues, enum2.enumValues);

+ enum1.enumValues, enum2.enumValues);

}

if (!element1.isObject) {

checkTypes(element1, element2, 'supertype',

element1.supertype, element2.supertype);

}

check(element1, element2, 'hierarchyDepth',

- element1.hierarchyDepth, element2.hierarchyDepth);

+ element1.hierarchyDepth, element2.hierarchyDepth);

checkTypeLists(

element1, element2, 'allSupertypes',

element1.allSupertypes.toList(),

element2.allSupertypes.toList());

OrderedTypeSet typeSet1 = element1.allSupertypesAndSelf;

- OrderedTypeSet typeSet2 = element1.allSupertypesAndSelf;

+ OrderedTypeSet typeSet2 = element2.allSupertypesAndSelf;

checkListEquivalence(

element1, element2, 'allSupertypes',

typeSet1.levelOffsets,

typeSet2.levelOffsets,

check);

check(element1, element2, 'allSupertypesAndSelf.levels',

- typeSet1.levels, typeSet2.levels);

+ typeSet1.levels, typeSet2.levels);

checkTypeLists(

element1, element2, 'supertypes',

typeSet1.supertypes.toList(),