Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2015903002: Compute and check members for serialization (Closed)

Created:
4 years, 7 months ago by Johnni Winther
Modified:
4 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : dartfmt #

Patch Set 4 : Rebased #

Patch Set 5 : Fix invariant #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -30 lines) Patch
M pkg/compiler/lib/src/resolution/class_hierarchy.dart View 1 2 3 1 chunk +2 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_members.dart View 1 2 2 chunks +24 lines, -12 lines 2 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 2 3 4 1 chunk +15 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 1 2 3 2 chunks +9 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/serialization/equivalence_test.dart View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
A tests/compiler/dart2js/serialization/members_test.dart View 1 1 chunk +157 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/serialization/test_helper.dart View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 6 months ago (2016-05-30 11:35:27 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2015903002/diff/80001/pkg/compiler/lib/src/resolution/class_members.dart File pkg/compiler/lib/src/resolution/class_members.dart (right): https://codereview.chromium.org/2015903002/diff/80001/pkg/compiler/lib/src/resolution/class_members.dart#newcode831 pkg/compiler/lib/src/resolution/class_members.dart:831: void _ensureInterfaceMembersAreClassMembers(Resolution resolution) { rename: change `ensure` to ...
4 years, 6 months ago (2016-05-31 16:28:32 UTC) #3
Johnni Winther
Committed patchset #5 (id:80001) manually as 7499d74f4b97905914f25ad82b4bb5b169b0ebd2 (presubmit successful).
4 years, 6 months ago (2016-06-02 09:00:38 UTC) #5
Johnni Winther
4 years, 6 months ago (2016-06-02 09:02:52 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2015903002/diff/80001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/class_members.dart (right):

https://codereview.chromium.org/2015903002/diff/80001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/class_members.dart:831: void
_ensureInterfaceMembersAreClassMembers(Resolution resolution) {
On 2016/05/31 16:28:31, Siggi Cherem (dart-lang) wrote:
> rename: change `ensure` to `compute`?
> 
> the current name suggest that you are trying to assert/ensure that all members
> of this class are class members.

Done.

Powered by Google App Engine
This is Rietveld 408576698