Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2015843002: [mojo-edk] Remove ChildProcessLaunched that returns a pipe handle. (Closed)

Created:
4 years, 7 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yusukes+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mojo-edk] Remove ChildProcessLaunched that returns a pipe handle. Committed: https://crrev.com/15cf85cc7263eac102b52277a950228e229ad71a Cr-Commit-Position: refs/heads/master@{#396320}

Patch Set 1 #

Patch Set 2 : compile fix #

Patch Set 3 : another fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -19 lines) Patch
M chrome/browser/chromeos/arc/gpu_arc_video_service_host.cc View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M components/arc/arc_bridge_bootstrap.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download
M mojo/edk/embedder/embedder.h View 1 chunk +1 line, -7 lines 0 comments Download
M mojo/edk/embedder/embedder.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Anand Mistry (off Chromium)
Cleanup.
4 years, 7 months ago (2016-05-26 05:45:52 UTC) #2
Ken Rockot(use gerrit already)
lgtm
4 years, 7 months ago (2016-05-26 05:51:07 UTC) #3
Anand Mistry (off Chromium)
elijahtaylor@chromium.org: Please review changes in arc.
4 years, 7 months ago (2016-05-26 05:59:01 UTC) #5
elijahtaylor1
added lhchavez, I'm not familiar enough with mojo to review this
4 years, 7 months ago (2016-05-26 21:58:18 UTC) #7
Luis Héctor Chávez
lgtm
4 years, 7 months ago (2016-05-26 22:03:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015843002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015843002/40001
4 years, 7 months ago (2016-05-26 23:40:08 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-26 23:45:46 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 23:47:59 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/15cf85cc7263eac102b52277a950228e229ad71a
Cr-Commit-Position: refs/heads/master@{#396320}

Powered by Google App Engine
This is Rietveld 408576698