Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2015833004: Fix circularity detection for AST-based type inference in the presence of closures. (Closed)

Created:
4 years, 7 months ago by Paul Berry
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix circularity detection for AST-based type inference in the presence of closures. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/0548ae7f3f1ada47bf8f2916d7d55d14931ff4c7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -17 lines) Patch
M pkg/analyzer/lib/src/summary/link.dart View 4 chunks +39 lines, -5 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_ast_test.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 3 chunks +38 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 7 months ago (2016-05-26 17:57:58 UTC) #2
scheglov
LGTM
4 years, 7 months ago (2016-05-26 18:20:30 UTC) #3
Paul Berry
4 years, 7 months ago (2016-05-26 19:01:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0548ae7f3f1ada47bf8f2916d7d55d14931ff4c7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698