Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Unified Diff: components/offline_pages/offline_page_model.h

Issue 2015793002: [Offline Pages] Linking storage manager and model with UMAs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@wisp
Patch Set: Adding more UMAs and hooking up model and storage manager. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model.h
diff --git a/components/offline_pages/offline_page_model.h b/components/offline_pages/offline_page_model.h
index 03aba53e238e2e1a87e6c0166cca27c268e70f04..df79989d2bfde31ea4d0d816635a4fdf1a8de2ed 100644
--- a/components/offline_pages/offline_page_model.h
+++ b/components/offline_pages/offline_page_model.h
@@ -340,6 +340,16 @@ class OfflinePageModel : public KeyedService,
const base::Time& expiration_time,
bool success);
+ // Calls storage manager to clear expired pages if there's any. Used to
jianli 2016/05/27 19:16:13 nit: you don't need to explain the implementation
romax 2016/05/27 20:36:02 Done.
+ // invoke ClearPagesIfNeeded on storage manager to clear storage
+ // 'automatically'.
+ void ClearStorageIfNeeded(
+ const OfflinePageStorageManager::ClearStorageCallback& callback);
+
+ // Callback completing storage clearing/
jianli 2016/05/27 19:16:13 nit: / => .
romax 2016/05/27 20:36:02 Done.
+ void OnStorageCleared(const size_t expired_page_count,
+ OfflinePageStorageManager::ClearStorageResult result);
+
void RunWhenLoaded(const base::Closure& job);
// Persistent store for offline page metadata.
« no previous file with comments | « no previous file | components/offline_pages/offline_page_model.cc » ('j') | components/offline_pages/offline_page_model.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698