Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2015793002: [Offline Pages] Linking storage manager and model with UMAs. (Closed)

Created:
4 years, 7 months ago by romax
Modified:
4 years, 6 months ago
Reviewers:
jianli, Steven Holte
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, asvitkine+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@wisp
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline Pages] Linking storage manager and model with UMAs. Hooking up storage manager and model, also adding UMAs for expiring pages/clearing storage. BUG=614895 Committed: https://crrev.com/871851cd7676eabcb85148dc357019d1b365f3f3 Cr-Commit-Position: refs/heads/master@{#396605}

Patch Set 1 #

Total comments: 8

Patch Set 2 : Adding more UMAs and hooking up model and storage manager. #

Total comments: 23

Patch Set 3 : Addressing comments. #

Total comments: 1

Patch Set 4 : comments. commit ready. #

Patch Set 5 : fixing typo in histograms.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -16 lines) Patch
M components/offline_pages/offline_page_model.h View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M components/offline_pages/offline_page_model.cc View 1 2 3 5 chunks +56 lines, -5 lines 0 comments Download
M components/offline_pages/offline_page_storage_manager.h View 1 2 3 chunks +10 lines, -6 lines 0 comments Download
M components/offline_pages/offline_page_storage_manager.cc View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 4 chunks +41 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
romax
Hi Jian, this is just kind of a draft... I'm sure you'll have questions for ...
4 years, 7 months ago (2016-05-26 01:37:30 UTC) #2
jianli
https://codereview.chromium.org/2015793002/diff/1/components/offline_pages/offline_page_model.cc File components/offline_pages/offline_page_model.cc (right): https://codereview.chromium.org/2015793002/diff/1/components/offline_pages/offline_page_model.cc#newcode534 components/offline_pages/offline_page_model.cc:534: // TODO(romax): Report UMA about successful expiration. Do you ...
4 years, 7 months ago (2016-05-26 20:37:52 UTC) #3
romax
Hi Jian, I've merged two patches since they're relatively close and small. I've added some ...
4 years, 7 months ago (2016-05-27 02:01:38 UTC) #4
jianli
https://codereview.chromium.org/2015793002/diff/20001/components/offline_pages/offline_page_model.cc File components/offline_pages/offline_page_model.cc (right): https://codereview.chromium.org/2015793002/diff/20001/components/offline_pages/offline_page_model.cc#newcode542 components/offline_pages/offline_page_model.cc:542: UMA_HISTOGRAM_COUNTS("OfflinePages.ExpirePage.StoreUpdateResult", You should use UMA_HISTOGRAM_BOOLEAN. https://codereview.chromium.org/2015793002/diff/20001/components/offline_pages/offline_page_model.cc#newcode546 components/offline_pages/offline_page_model.cc:546: auto iter ...
4 years, 6 months ago (2016-05-27 19:16:13 UTC) #5
romax
Addressed comments. https://codereview.chromium.org/2015793002/diff/20001/components/offline_pages/offline_page_model.cc File components/offline_pages/offline_page_model.cc (right): https://codereview.chromium.org/2015793002/diff/20001/components/offline_pages/offline_page_model.cc#newcode542 components/offline_pages/offline_page_model.cc:542: UMA_HISTOGRAM_COUNTS("OfflinePages.ExpirePage.StoreUpdateResult", On 2016/05/27 19:16:12, jianli wrote: > ...
4 years, 6 months ago (2016-05-27 20:36:02 UTC) #6
jianli
lgtm Please also update the issue body. https://codereview.chromium.org/2015793002/diff/20001/components/offline_pages/offline_page_model.cc File components/offline_pages/offline_page_model.cc (right): https://codereview.chromium.org/2015793002/diff/20001/components/offline_pages/offline_page_model.cc#newcode554 components/offline_pages/offline_page_model.cc:554: base::TimeDelta::FromDays(30).InMinutes(), 120); ...
4 years, 6 months ago (2016-05-27 20:46:21 UTC) #7
romax
Adding holte@ for histogram changes. PTAL. Thanks!
4 years, 6 months ago (2016-05-27 21:05:05 UTC) #9
Steven Holte
lgtm
4 years, 6 months ago (2016-05-27 21:10:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015793002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015793002/80001
4 years, 6 months ago (2016-05-27 22:46:13 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 6 months ago (2016-05-28 00:07:13 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-05-28 00:09:03 UTC) #18
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/871851cd7676eabcb85148dc357019d1b365f3f3
Cr-Commit-Position: refs/heads/master@{#396605}

Powered by Google App Engine
This is Rietveld 408576698