Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Issue 2015763003: [tracing] Support background mode in skia memory dump provider (Closed)

Created:
4 years, 7 months ago by ssid
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@whitelist_mdp
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tracing] Support background mode in skia memory dump provider Background mode requires quick dump and just the totals, to be able to collect traces in the background for all users. Skia dump provider adds just the cache sizes in background mode. BUG=613198 Committed: https://crrev.com/83ec5cba3d1f054875044a674c34aec22c2033c3 Cr-Commit-Position: refs/heads/master@{#397552}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M skia/ext/skia_memory_dump_provider.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (7 generated)
ssid
+primiano, I will add skia reviewers if you think this change is fine. Thanks
4 years, 6 months ago (2016-05-31 23:04:27 UTC) #2
Primiano Tucci (use gerrit)
non-owner LGTM. This seems simple and fast. Maybe you want to add a bit of ...
4 years, 6 months ago (2016-06-02 19:35:10 UTC) #3
ssid
+reed PTAL Thanks.
4 years, 6 months ago (2016-06-02 20:08:07 UTC) #7
reed1
skia lgtm -- those skia apis are very cheap/fast.
4 years, 6 months ago (2016-06-02 20:11:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015763003/1
4 years, 6 months ago (2016-06-02 20:56:28 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 00:14:51 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 00:16:13 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83ec5cba3d1f054875044a674c34aec22c2033c3
Cr-Commit-Position: refs/heads/master@{#397552}

Powered by Google App Engine
This is Rietveld 408576698