Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2015753002: Angular template workarounds (Closed)

Created:
4 years, 7 months ago by Leaf
Modified:
4 years, 7 months ago
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Jacobs changes #

Patch Set 4 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -3 lines) Patch
M lib/src/compiler/code_generator.dart View 1 2 3 10 chunks +31 lines, -3 lines 2 comments Download

Messages

Total messages: 6 (3 generated)
Jacob
lgtm lgtm. This is elegant code.
4 years, 7 months ago (2016-05-26 00:30:36 UTC) #2
Leaf
Committed patchset #4 (id:60001) manually as ceae9500bfaf3c138923d7bcf860a770b2f4cb0f (presubmit successful).
4 years, 7 months ago (2016-05-26 05:44:06 UTC) #4
Jennifer Messerly
4 years, 7 months ago (2016-05-26 18:19:02 UTC) #6
Message was sent while issue was closed. 
this has some pretty big issues...

https://codereview.chromium.org/2015753002/diff/60001/lib/src/compiler/code_g...
File lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2015753002/diff/60001/lib/src/compiler/code_g...
lib/src/compiler/code_generator.dart:429: _inAngularTemplate =
can we have this guarded by a compile flag please?

https://codereview.chromium.org/2015753002/diff/60001/lib/src/compiler/code_g...
lib/src/compiler/code_generator.dart:430:
unit.element.source.fullName.endsWith(".template.dart");
So, this doesn't work... I should put a comment on visitCompilationUnit saying
"don't put stuff here!"

We don't visit things in order. So you'll end up affecting arbitrary other
libraries that aren't in .template.dart files.

The right way to check for this at the place of use. See how currentLibrary
works.

You can also do per-compilation-unit caching in _emitModuleItem.

Powered by Google App Engine
This is Rietveld 408576698