Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2015743002: Banish CFX_PrivateData to the XFA side (Closed)

Created:
4 years, 7 months ago by Tom Sepez
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Banish CFX_PrivateData to the XFA side Remove an unused inheritance. The remaining usages are a little more intricate. Committed: https://pdfium.googlesource.com/pdfium/+/7fa5513e973f9ee6bd34b9ca1e76ad208598191f

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M core/fxcodec/codec/ccodec_iccmodule.h View 1 chunk +0 lines, -1 line 0 comments Download
M core/fxcrt/fx_basic_util.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M core/fxcrt/include/fx_basic.h View 2 chunks +3 lines, -1 line 0 comments Download
M xfa/fxfa/include/xfa_ffwidget.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Tom Sepez
Lei, for review.
4 years, 7 months ago (2016-05-25 23:39:10 UTC) #3
Lei Zhang
lgtm
4 years, 7 months ago (2016-05-25 23:42:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015743002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015743002/20001
4 years, 7 months ago (2016-05-25 23:56:59 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 23:57:14 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/7fa5513e973f9ee6bd34b9ca1e76ad208598...

Powered by Google App Engine
This is Rietveld 408576698