Chromium Code Reviews

Issue 201573012: fix FunctionCallbackInfo ambiguity (Closed)

Created:
6 years, 9 months ago by dcarney
Modified:
6 years, 9 months ago
Reviewers:
Sven Panne
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

fix FunctionCallbackInfo ambiguity - when compiling tools that embed v8 with g++ FunctionCallbackInfo is currently ambigous - more info: https://github.com/joyent/node/issues/7337 - original patch is here: https://codereview.appspot.com/78770045/ TBR=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20217

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+1 line, -0 lines)
M include/v8.h View 1 chunk +1 line, -0 lines 0 comments

Messages

Total messages: 2 (0 generated)
dcarney
Committed patchset #1 manually as r20217 (presubmit successful).
6 years, 9 months ago (2014-03-24 19:37:06 UTC) #1
Sven Panne
6 years, 9 months ago (2014-03-25 06:49:48 UTC) #2
Message was sent while issue was closed.
lgtm

Powered by Google App Engine