Fix false x64 argument index assertion

Fix to get around an assertion that triggers when generating code that happens to be dead because the assertion is checked a bit earlier at runtime.

R=ishell@chromium.org
BUG=355486
LOG=N

Committed: https://code.google.com/p/v8/source/detail?r=20218

[Igor Sheludko, 2014-03-24 15:23:28]

https://codereview.chromium.org/201573011/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):

https://codereview.chromium.org/201573011/diff/1/src/x64/lithium-codegen-x64....
src/x64/lithium-codegen-x64.cc:2927: __ Abort(kInvalidArgumentIndex);
Abort() calls runtime which requires context to be in rsi but this instruction
does not handle context. Most likely it will crash if ever hits the Abort()
case. I'm not fully sure but probably you should use int3() here.

[Igor Sheludko, 2014-03-24 15:33:31]

https://codereview.chromium.org/201573011/diff/1/test/mjsunit/regress/regress...
File test/mjsunit/regress/regress-355486.js (right):

https://codereview.chromium.org/201573011/diff/1/test/mjsunit/regress/regress...
test/mjsunit/regress/regress-355486.js:7: function __f_17() {
Please rename identifiers without underscores and numbers.

[Jarin, 2014-03-24 16:36:05]

Should be fixed now. Thanks!

https://codereview.chromium.org/201573011/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):

https://codereview.chromium.org/201573011/diff/1/src/x64/lithium-codegen-x64....
src/x64/lithium-codegen-x64.cc:2927: __ Abort(kInvalidArgumentIndex);
On 2014/03/24 15:23:28, Igor Sheludko wrote:
> Abort() calls runtime which requires context to be in rsi but this instruction
> does not handle context. Most likely it will crash if ever hits the Abort()
> case. I'm not fully sure but probably you should use int3() here.

Done.

https://codereview.chromium.org/201573011/diff/1/test/mjsunit/regress/regress...
File test/mjsunit/regress/regress-355486.js (right):

https://codereview.chromium.org/201573011/diff/1/test/mjsunit/regress/regress...
test/mjsunit/regress/regress-355486.js:7: function __f_17() {
On 2014/03/24 15:33:31, Igor Sheludko wrote:
> Please rename identifiers without underscores and numbers.

Done.

[Igor Sheludko, 2014-03-24 16:37:46]

lgtm

[Jarin, 2014-03-24 20:51:43]

Committed patchset #2 manually as r20218 (presubmit successful).