Remove -webkit-column-progression and -webkit-column-axis properties.

Remove -webkit-column-progression and -webkit-column-axis properties.

Only needed by Apple's setPagination API, which doesn't exist in Blink anymore.

Link to "intent to remove" post:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/7n-oLhmTkuM

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170043

[Julien - ping for review, 2014-03-25 18:52:53]

lgtm with some changes:
- Please link to the intent to remove blink-dev post.
- Remove the BUG=None entry (we prefer not to put them in Blink)

https://codereview.chromium.org/201573009/diff/1/Source/core/frame/UseCounter...
File Source/core/frame/UseCounter.cpp (right):

https://codereview.chromium.org/201573009/diff/1/Source/core/frame/UseCounter...
Source/core/frame/UseCounter.cpp:267: //    case CSSPropertyWebkitColumnAxis:
return 214;
A) We should align the comment with the case statements.
B) We shouldn't have a gap of 4 characters between the start of comment and the
actual text.
C) I much prefer some English comment that explained what was removed + the
value (it's a nit as we are very inconsistent in this file).

https://codereview.chromium.org/201573009/diff/1/Source/core/frame/UseCounter...
Source/core/frame/UseCounter.cpp:273: //    case
CSSPropertyWebkitColumnProgression: return 220;
Ditto.

https://codereview.chromium.org/201573009/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderBlock.cpp (right):

https://codereview.chromium.org/201573009/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderBlock.cpp:3346: info->setDesiredColumnCount(1);
This seems like an existing bug in the code. Any chance this could be covered by
some (existing or new) test?

[mstensho (USE GERRIT), 2014-03-26 09:03:22]

https://codereview.chromium.org/201573009/diff/1/Source/core/frame/UseCounter...
File Source/core/frame/UseCounter.cpp (right):

https://codereview.chromium.org/201573009/diff/1/Source/core/frame/UseCounter...
Source/core/frame/UseCounter.cpp:267: //    case CSSPropertyWebkitColumnAxis:
return 214;
On 2014/03/25 18:52:53, Julien Chaffraix - PST wrote:
> A) We should align the comment with the case statements.
> B) We shouldn't have a gap of 4 characters between the start of comment and
the
> actual text.
> C) I much prefer some English comment that explained what was removed + the
> value (it's a nit as we are very inconsistent in this file).

A&B: Disagrees with how emacs indents by default, but sure, it looked silly. :)
Done.

C: Done. We ought to go through all the removed properties in that file and come
up with some kind of common style.

https://codereview.chromium.org/201573009/diff/1/Source/core/frame/UseCounter...
Source/core/frame/UseCounter.cpp:273: //    case
CSSPropertyWebkitColumnProgression: return 220;
On 2014/03/25 18:52:53, Julien Chaffraix - PST wrote:
> Ditto.

Done.

https://codereview.chromium.org/201573009/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderBlock.cpp (right):

https://codereview.chromium.org/201573009/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderBlock.cpp:3346: info->setDesiredColumnCount(1);
On 2014/03/25 18:52:53, Julien Chaffraix - PST wrote:
> This seems like an existing bug in the code. Any chance this could be covered
by
> some (existing or new) test?

I cannot actually find any problems with just leaving column count alone here
when checking now, but it just looked too silly to leave it at whatever. There's
code in RenderStyle that forces renderer reattach if column-width and
column-count changes. This hides whatever bugs that may be caused by failing to
set column count to 1 here.

Anyway, this is old multicol code, so I prefer not spending any more time on it.

[mstensho (USE GERRIT), 2014-03-26 09:03:29]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2014-03-26 09:03:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mstensho@opera.com/201573009/60001

[commit-bot: I haz the power, 2014-03-26 09:03:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-26 09:03:56]

Failed to apply patch for
LayoutTests/fast/multicol/recursive-split-flow-crash.html:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/fast/multicol/recursive-split-flow-crash.html
  Hunk #1 FAILED at 28.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/fast/multicol/recursive-split-flow-crash.html.rej

Patch:       LayoutTests/fast/multicol/recursive-split-flow-crash.html
Index: LayoutTests/fast/multicol/recursive-split-flow-crash.html
diff --git a/LayoutTests/fast/multicol/recursive-split-flow-crash.html
b/LayoutTests/fast/multicol/recursive-split-flow-crash.html
index
2d616011c1c984b4237b2d261a6c8ef6128a1693..74d34f84738e57a4161c4e33b4b78dae0b05305d
100644
--- a/LayoutTests/fast/multicol/recursive-split-flow-crash.html
+++ b/LayoutTests/fast/multicol/recursive-split-flow-crash.html
@@ -28,7 +28,6 @@ document.execCommand("SelectAll", true);
 styleSheet0.insertRule('.testClass { -webkit-column-span: all ; }', 0);
 test1.appendChild(test2);
 styleSheet0.insertRule('.testClass::first-letter { border-style: none; }', 0);
-styleSheet0.insertRule('.container { -webkit-column-axis: vertical; }', 0);
 </script>
 </body>
 </html>
\ No newline at end of file

[mstensho (USE GERRIT), 2014-03-26 10:16:25]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2014-03-26 10:16:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mstensho@opera.com/201573009/130001

[commit-bot: I haz the power, 2014-03-26 10:46:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-26 10:46:07]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_rel

[mstensho (USE GERRIT), 2014-03-26 10:53:58]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2014-03-26 10:54:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mstensho@opera.com/201573009/130001

[commit-bot: I haz the power, 2014-03-26 11:29:49]

Change committed as 170043