Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 201573006: Cleaned up MediaQueryExp creation from BisonCSSParser (Closed)

Created:
6 years, 9 months ago by Yoav Weiss
Modified:
6 years, 9 months ago
Reviewers:
esprehn, eseidel
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@mqexp_create
Visibility:
Public.

Description

Clean up parseMediaQueryList from BisonCSSParser Following https://codereview.chromium.org/171383002/ BisonCSSParser::parseMediaQueryList is no longer used. This CL removes that unused code. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169808

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M Source/core/css/parser/BisonCSSParser.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Yoav Weiss
6 years, 9 months ago (2014-03-22 16:52:24 UTC) #1
eseidel
lgtm
6 years, 9 months ago (2014-03-22 17:33:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/201573006/1
6 years, 9 months ago (2014-03-22 17:33:48 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-22 18:38:10 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-22 18:38:11 UTC) #5
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 9 months ago (2014-03-22 22:38:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/201573006/1
6 years, 9 months ago (2014-03-22 22:38:03 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-22 23:17:30 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-22 23:17:30 UTC) #9
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 9 months ago (2014-03-23 00:14:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/201573006/1
6 years, 9 months ago (2014-03-23 00:15:00 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-23 00:52:52 UTC) #12
Message was sent while issue was closed. 
Change committed as 169808

Powered by Google App Engine
This is Rietveld 408576698