Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1395)

Unified Diff: build/android/pylib/utils/test_environment.py

Issue 2015723003: [Android] Attempt to continue after single-device failure in cleanup_device. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/utils/test_environment.py
diff --git a/build/android/pylib/utils/test_environment.py b/build/android/pylib/utils/test_environment.py
index 0a1326e7cb936f65a185725062e033c7e48c2058..732140c33b334efc51b423199420e6a1ca8de2bd 100644
--- a/build/android/pylib/utils/test_environment.py
+++ b/build/android/pylib/utils/test_environment.py
@@ -40,13 +40,13 @@ def CleanupLeftoverProcesses(devices):
device_utils.RestartServer()
def cleanup_device(d):
- d.WaitUntilFullyBooted()
- d.RestartAdbd()
try:
+ d.WaitUntilFullyBooted()
+ d.RestartAdbd()
d.EnableRoot()
+ d.WaitUntilFullyBooted()
except device_errors.CommandFailedError:
- logging.exception('Failed to enable root')
- d.WaitUntilFullyBooted()
+ logging.exception('Failed to clean up device. Attempting to continue.')
device_utils.DeviceUtils.parallel(devices).pMap(cleanup_device)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698