Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2015713002: Resolve console output in postMessage tests with site-per-process. (Closed)

Created:
4 years, 7 months ago by dgozman
Modified:
4 years, 7 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Resolve console output in postMessage tests with site-per-process. Regular tests do not dump console output anymore, and special same-site test does it. BUG=614413 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/6b50e7bb8127b82d23787cb4ee1975a6e3758c82 Cr-Commit-Position: refs/heads/master@{#396055}

Patch Set 1 #

Total comments: 3

Patch Set 2 : bug reference #

Messages

Total messages: 13 (6 generated)
dgozman
Could you please take a look? What's the name of site-per-process bot to use in ...
4 years, 7 months ago (2016-05-25 22:23:58 UTC) #2
Łukasz Anforowicz
lgtm with nits. Thanks! You can use: CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation I've also tried patching in your CL ...
4 years, 7 months ago (2016-05-25 22:35:30 UTC) #3
alexmos
LGTM
4 years, 7 months ago (2016-05-25 23:04:16 UTC) #4
dgozman
https://codereview.chromium.org/2015713002/diff/1/third_party/WebKit/LayoutTests/http/tests/security/postMessage/invalid-origin-throws-exception.html File third_party/WebKit/LayoutTests/http/tests/security/postMessage/invalid-origin-throws-exception.html (right): https://codereview.chromium.org/2015713002/diff/1/third_party/WebKit/LayoutTests/http/tests/security/postMessage/invalid-origin-throws-exception.html#newcode8 third_party/WebKit/LayoutTests/http/tests/security/postMessage/invalid-origin-throws-exception.html:8: // We have different console output in --site-per-process mode. ...
4 years, 7 months ago (2016-05-25 23:10:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015713002/20001
4 years, 7 months ago (2016-05-25 23:11:37 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-26 00:35:06 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 00:38:04 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6b50e7bb8127b82d23787cb4ee1975a6e3758c82
Cr-Commit-Position: refs/heads/master@{#396055}

Powered by Google App Engine
This is Rietveld 408576698