Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 2015703002: bluetooth: Remove UriBeacon code (Closed)

Created:
4 years, 7 months ago by ortuno
Modified:
4 years, 7 months ago
Reviewers:
scheib
CC:
chromium-reviews, mattreynolds, ortuno+watch_chromium.org, scheib+watch_chromium.org, Olivier
Base URL:
https://chromium.googlesource.com/chromium/src.git@my-origin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Remove UriBeacon code This code was introduced by the Physical Web team when they were exploring integration with Chrome. They ended up going a different route so this code is useless now. Committed: https://crrev.com/3d392de68c541604a01a0c077c44d0ba4c7a02c7 Cr-Commit-Position: refs/heads/master@{#396112}

Patch Set 1 #

Patch Set 2 : Delete target #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -298 lines) Patch
M device/bluetooth/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth.gyp View 1 2 chunks +0 lines, -13 lines 0 comments Download
D device/bluetooth/uribeacon/BUILD.gn View 1 chunk +0 lines, -13 lines 0 comments Download
D device/bluetooth/uribeacon/uri_encoder.h View 1 chunk +0 lines, -44 lines 0 comments Download
D device/bluetooth/uribeacon/uri_encoder.cc View 1 chunk +0 lines, -132 lines 0 comments Download
D device/bluetooth/uribeacon/uri_encoder_unittest.cc View 1 chunk +0 lines, -95 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
ortuno
scheib: PTAL
4 years, 7 months ago (2016-05-25 22:14:51 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015703002/1
4 years, 7 months ago (2016-05-25 22:15:34 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/218502)
4 years, 7 months ago (2016-05-25 22:49:06 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015703002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015703002/20001
4 years, 7 months ago (2016-05-25 23:27:46 UTC) #8
scheib
LGTM
4 years, 7 months ago (2016-05-25 23:37:06 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-26 03:43:39 UTC) #11
commit-bot: I haz the power
Dry run: None
4 years, 7 months ago (2016-05-26 03:43:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015703002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015703002/20001
4 years, 7 months ago (2016-05-26 03:55:42 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-26 04:00:32 UTC) #15
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/3d392de68c541604a01a0c077c44d0ba4c7a02c7 Cr-Commit-Position: refs/heads/master@{#396112}
4 years, 7 months ago (2016-05-26 04:02:36 UTC) #17
sdefresne
This code is still used by Chrome on iOS in our downstream repository. We are ...
4 years, 7 months ago (2016-05-26 06:34:42 UTC) #18
Olivier
4 years, 7 months ago (2016-05-26 07:39:01 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2014813002/ by olivierrobin@chromium.org.

The reason for reverting is: This code is still used on iOS. The code will be
upstreamed soon, but at the moment some dependencies prevent it..

Powered by Google App Engine
This is Rietveld 408576698