gpu: Fix a bug in the new ReturnFrontBuffer() path for pepper.

gpu: Fix a bug in the new ReturnFrontBuffer() path for pepper.

|offscreen_saved_frame_buffer_| is used for multisampled buffers, and a
workaround. An implicit assumption of GLES2CmdDecoder is that
|offscreen_saved_color_texture_| is always bound to
|offscreen_saved_frame_buffer_|. The new ReturnFrontBuffer() logic violated this
assumption.

BUG=611016
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/95ab6d12e8518a9d86abc9b694b9b023543ba5bd
Cr-Commit-Position: refs/heads/master@{#396129}

[erikchen, 2016-05-25 22:11:11]

Description was changed from

==========
gpu: Fix a bug in the new ReturnFrontBuffer() path for pepper.

|offscreen_saved_frame_buffer_| is used for multisampled buffers, and a
workaround. An implicit assumption of GLES2CmdDecoder is that
|offscreen_saved_color_texture_| is always bound to
|offscreen_saved_frame_buffer_|. The new ReturnFrontBuffer() logic violated this
assumption.

BUG=611016
==========

to

==========
gpu: Fix a bug in the new ReturnFrontBuffer() path for pepper.

|offscreen_saved_frame_buffer_| is used for multisampled buffers, and a
workaround. An implicit assumption of GLES2CmdDecoder is that
|offscreen_saved_color_texture_| is always bound to
|offscreen_saved_frame_buffer_|. The new ReturnFrontBuffer() logic violated this
assumption.

BUG=611016
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[erikchen, 2016-05-25 22:21:53]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-25 22:23:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2015693002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2015693002/40001

[erikchen, 2016-05-25 22:25:25]

erikchen@chromium.org changed reviewers:
+ piman@chromium.org

[erikchen, 2016-05-25 22:25:26]

piman: Please review.

As per usual, the test fails without the fix, and passes after the fix.

[piman, 2016-05-25 22:32:10]

LGTM, thanks for tracking it down.

[commit-bot: I haz the power, 2016-05-26 03:38:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-26 03:38:49]

Dry run: Try jobs failed on following builders:
  linux_optional_gpu_tests_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)

[erikchen, 2016-05-26 05:01:50]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-05-26 05:02:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2015693002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2015693002/40001

[commit-bot: I haz the power, 2016-05-26 05:55:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-26 05:56:37]

Description was changed from

==========
gpu: Fix a bug in the new ReturnFrontBuffer() path for pepper.

|offscreen_saved_frame_buffer_| is used for multisampled buffers, and a
workaround. An implicit assumption of GLES2CmdDecoder is that
|offscreen_saved_color_texture_| is always bound to
|offscreen_saved_frame_buffer_|. The new ReturnFrontBuffer() logic violated this
assumption.

BUG=611016
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
gpu: Fix a bug in the new ReturnFrontBuffer() path for pepper.

|offscreen_saved_frame_buffer_| is used for multisampled buffers, and a
workaround. An implicit assumption of GLES2CmdDecoder is that
|offscreen_saved_color_texture_| is always bound to
|offscreen_saved_frame_buffer_|. The new ReturnFrontBuffer() logic violated this
assumption.

BUG=611016
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/95ab6d12e8518a9d86abc9b694b9b023543ba5bd
Cr-Commit-Position: refs/heads/master@{#396129}
==========

[commit-bot: I haz the power, 2016-05-26 05:56:38]

Patchset 3 (id:??) landed as
https://crrev.com/95ab6d12e8518a9d86abc9b694b9b023543ba5bd
Cr-Commit-Position: refs/heads/master@{#396129}