Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2015673003: Use correct signature for custom constructor of CustomEvent (Closed)

Created:
4 years, 7 months ago by bashi
Modified:
4 years, 7 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use correct signature for custom constructor of CustomEvent This will make CustomEvent.length return the correct value (which is "1"). BUG=614036 Committed: https://crrev.com/01fcbfb8573898b017ef81c7d37dc871f8d19309 Cr-Commit-Position: refs/heads/master@{#396143}

Patch Set 1 #

Patch Set 2 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/fast/js/constructor-length.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/js/constructor-length-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/dom/interfaces-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/CustomEvent.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
bashi
PTAL?
4 years, 7 months ago (2016-05-26 00:38:43 UTC) #2
haraken
LGTM
4 years, 7 months ago (2016-05-26 00:42:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015673003/1
4 years, 7 months ago (2016-05-26 01:20:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/234210)
4 years, 7 months ago (2016-05-26 02:42:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015673003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015673003/20001
4 years, 7 months ago (2016-05-26 02:51:48 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-26 07:41:37 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 07:42:51 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/01fcbfb8573898b017ef81c7d37dc871f8d19309
Cr-Commit-Position: refs/heads/master@{#396143}

Powered by Google App Engine
This is Rietveld 408576698