Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Issue 2015663002: Adjust indeterminate progress bar animation (Closed)

Created:
4 years, 7 months ago by mdjones
Modified:
4 years, 6 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust indeterminate progress bar animation - Triggering time is 5s instead of 3s. - Disable animation on JellyBean. - Animation width is 30% of progress instead of 50%. - Two-step animation is now slow then fast. - Animation duration is a function of progress bar length. - Indeterminate animation has max dp width of 400. BUG=464377 Committed: https://crrev.com/ae9b6cdaa5d09c4e243f9f1ee25cb07ba07ae965 Cr-Commit-Position: refs/heads/master@{#400688}

Patch Set 1 #

Patch Set 2 : nits #

Patch Set 3 : use different curve #

Patch Set 4 : more adjustments #

Patch Set 5 : fix early return #

Total comments: 6

Patch Set 6 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -32 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBarAnimatingView.java View 1 2 3 4 5 11 chunks +90 lines, -30 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
mdjones
ptal
4 years, 6 months ago (2016-06-07 00:27:11 UTC) #2
mdjones
On 2016/06/07 00:27:11, mdjones wrote: > ptal Spec is listed in the issue.
4 years, 6 months ago (2016-06-07 00:27:32 UTC) #3
gone
https://chromiumcodereview.appspot.com/2015663002/diff/80001/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBarAnimatingView.java File chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBarAnimatingView.java (right): https://chromiumcodereview.appspot.com/2015663002/diff/80001/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBarAnimatingView.java#newcode95 chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBarAnimatingView.java:95: private boolean mIsAnimationRunning; Jellybean support is gone. https://chromiumcodereview.appspot.com/2015663002/diff/80001/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBarAnimatingView.java#newcode152 chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBarAnimatingView.java:152: ...
4 years, 6 months ago (2016-06-07 17:54:27 UTC) #4
mdjones
https://chromiumcodereview.appspot.com/2015663002/diff/80001/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBarAnimatingView.java File chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBarAnimatingView.java (right): https://chromiumcodereview.appspot.com/2015663002/diff/80001/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBarAnimatingView.java#newcode95 chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBarAnimatingView.java:95: private boolean mIsAnimationRunning; On 2016/06/07 17:54:26, dfalcantara wrote: > ...
4 years, 6 months ago (2016-06-07 18:18:04 UTC) #5
gone
lgtm
4 years, 6 months ago (2016-06-07 18:40:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015663002/100001
4 years, 6 months ago (2016-06-20 15:19:40 UTC) #8
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 6 months ago (2016-06-20 15:53:56 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 15:58:27 UTC) #11
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/ae9b6cdaa5d09c4e243f9f1ee25cb07ba07ae965
Cr-Commit-Position: refs/heads/master@{#400688}

Powered by Google App Engine
This is Rietveld 408576698