Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 2015653002: cc: Visible Rect Calculation use RectF between transformations (Closed)

Created:
4 years, 7 months ago by weiliangc
Modified:
4 years, 6 months ago
Reviewers:
ajuma
CC:
cc-bugs_chromium.org, chromium-reviews, enne (OOO), jaydasika, Ian Vollick
Base URL:
https://chromium.googlesource.com/chromium/src.git@separateclipvis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Visible Rect Calculation use RectF between transformations Currently visible rect calculation expands to enclosing rect in target space, and then transform to layer space, and expand to enclosing rect in layer space again. Remove the first expansion to rect. R=ajuma BUG=594675 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/d15784430af415d27d64ff504cfc8cc4c86f2f29 Cr-Commit-Position: refs/heads/master@{#398333}

Patch Set 1 #

Patch Set 2 : use rectF #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -43 lines) Patch
M cc/trees/draw_property_utils.cc View 1 2 12 chunks +32 lines, -35 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 2 3 chunks +4 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
weiliangc
On top of separating, try to use RectF as much as possible. This should make ...
4 years, 7 months ago (2016-05-25 20:09:31 UTC) #2
ajuma
lgtm
4 years, 7 months ago (2016-05-25 20:59:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015653002/40001
4 years, 6 months ago (2016-06-07 16:32:15 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-07 17:57:45 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 18:00:05 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d15784430af415d27d64ff504cfc8cc4c86f2f29
Cr-Commit-Position: refs/heads/master@{#398333}

Powered by Google App Engine
This is Rietveld 408576698