Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: examples/media_test/media_test_app.cc

Issue 2015643002: Add (optional) options to Run[Main]Application(). (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: doh Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: examples/media_test/media_test_app.cc
diff --git a/examples/media_test/media_test_app.cc b/examples/media_test/media_test_app.cc
index ff4ba3dc745a69bc90b0d9a0fc4d762d8a22df70..3ce8e8a8efd5ab5d26a2089f127ade0ae0ec127d 100644
--- a/examples/media_test/media_test_app.cc
+++ b/examples/media_test/media_test_app.cc
@@ -7,27 +7,26 @@
#include <iostream>
#include "base/bind.h"
+#include "base/message_loop/message_loop.h"
#include "examples/media_test/keystroke.h"
#include "examples/media_test/media_test.h"
-#include "mojo/application/application_runner_chromium.h"
#include "mojo/public/c/system/main.h"
-#include "mojo/public/cpp/application/application_delegate.h"
-#include "mojo/public/cpp/application/application_impl.h"
+#include "mojo/public/cpp/application/application_impl_base.h"
+#include "mojo/public/cpp/application/run_application.h"
namespace mojo {
namespace media {
namespace examples {
-class MediaTestApp : public mojo::ApplicationDelegate {
+class MediaTestApp : public mojo::ApplicationImplBase {
public:
MediaTestApp() {}
~MediaTestApp() override {}
- // ApplicationDelegate implementation.
- void Initialize(mojo::ApplicationImpl* app) override {
- app_ = app;
- ProcessArgs(app->args());
+ // ApplicationImplBase overrides.
+ void OnInitialize() override {
+ ProcessArgs(args());
std::cout << std::endl << "MEDIA TEST" << std::endl << std::endl;
@@ -95,7 +94,7 @@ class MediaTestApp : public mojo::ApplicationDelegate {
// input_file_names_iter_.
void CreateNewMediaTest() {
MOJO_DCHECK(input_file_names_iter_ != input_file_names_.end());
- media_test_ = MediaTest::Create(app_, *input_file_names_iter_);
+ media_test_ = MediaTest::Create(shell(), *input_file_names_iter_);
metadata_shown_ = false;
media_test_->RegisterUpdateCallback(
@@ -294,7 +293,6 @@ class MediaTestApp : public mojo::ApplicationDelegate {
const char* clear_line() const { return paint_ ? kClearLine : ""; }
- mojo::ApplicationImpl* app_;
std::unique_ptr<MediaTest> media_test_;
std::deque<std::string> input_file_names_;
decltype(input_file_names_.begin()) input_file_names_iter_;
@@ -315,7 +313,6 @@ const char* MediaTestApp::kUp = "\033[A";
} // namespace mojo
MojoResult MojoMain(MojoHandle application_request) {
- mojo::ApplicationRunnerChromium runner(
- new mojo::media::examples::MediaTestApp);
- return runner.Run(application_request);
+ mojo::media::examples::MediaTestApp media_test_app;
+ return mojo::RunMainApplication(application_request, &media_test_app);
}

Powered by Google App Engine
This is Rietveld 408576698