Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: services/native_support/main.cc

Issue 2015643002: Add (optional) options to Run[Main]Application(). (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: doh Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/macros.h" 5 #include "base/macros.h"
6 #include "base/memory/ref_counted.h" 6 #include "base/memory/ref_counted.h"
7 #include "base/message_loop/message_loop.h" 7 #include "base/message_loop/message_loop.h"
8 #include "base/threading/sequenced_worker_pool.h" 8 #include "base/threading/sequenced_worker_pool.h"
9 #include "mojo/application/application_runner_chromium.h" 9 #include "mojo/application/run_application_options_chromium.h"
10 #include "mojo/public/c/system/main.h" 10 #include "mojo/public/c/system/main.h"
11 #include "mojo/public/cpp/application/application_delegate.h" 11 #include "mojo/public/cpp/application/application_impl_base.h"
12 #include "mojo/public/cpp/application/run_application.h"
12 #include "mojo/public/cpp/application/service_provider_impl.h" 13 #include "mojo/public/cpp/application/service_provider_impl.h"
13 #include "mojo/services/native_support/interfaces/process.mojom.h" 14 #include "mojo/services/native_support/interfaces/process.mojom.h"
14 #include "services/native_support/process_impl.h" 15 #include "services/native_support/process_impl.h"
15 16
16 namespace native_support { 17 namespace native_support {
17 18
18 // TODO(vtl): Having to manually choose an arbitrary number is dumb. 19 // TODO(vtl): Having to manually choose an arbitrary number is dumb.
19 const size_t kMaxWorkerThreads = 16; 20 const size_t kMaxWorkerThreads = 16;
20 21
21 class NativeSupportApp : public mojo::ApplicationDelegate { 22 class NativeSupportApp : public mojo::ApplicationImplBase {
22 public: 23 public:
23 NativeSupportApp() {} 24 NativeSupportApp() {}
24 ~NativeSupportApp() override { 25 ~NativeSupportApp() override {
25 if (worker_pool_) 26 // TODO(vtl): Doing this here is a bit of a hack, but we may not
26 worker_pool_->Shutdown(); 27 // consistently call |OnQuit()|.
28 OnQuit();
27 } 29 }
28 30
29 private: 31 private:
30 // |mojo::ApplicationDelegate| override: 32 // |mojo::ApplicationImplBase| overrides:
31 bool ConfigureIncomingConnection( 33 bool OnAcceptConnection(
32 mojo::ServiceProviderImpl* service_provider_impl) override { 34 mojo::ServiceProviderImpl* service_provider_impl) override {
33 service_provider_impl->AddService<Process>([this]( 35 service_provider_impl->AddService<Process>([this](
34 const mojo::ConnectionContext& connection_context, 36 const mojo::ConnectionContext& connection_context,
35 mojo::InterfaceRequest<Process> process_request) { 37 mojo::InterfaceRequest<Process> process_request) {
36 if (!worker_pool_) { 38 if (!worker_pool_) {
37 worker_pool_ = new base::SequencedWorkerPool(kMaxWorkerThreads, 39 worker_pool_ = new base::SequencedWorkerPool(kMaxWorkerThreads,
38 "NativeSupportWorker"); 40 "NativeSupportWorker");
39 } 41 }
40 new ProcessImpl(worker_pool_, connection_context, process_request.Pass()); 42 new ProcessImpl(worker_pool_, connection_context, process_request.Pass());
41 }); 43 });
42 return true; 44 return true;
43 } 45 }
44 46
47 void OnQuit() override {
48 if (worker_pool_) {
49 worker_pool_->Shutdown();
50 worker_pool_ = nullptr;
51 }
52 }
53
45 scoped_refptr<base::SequencedWorkerPool> worker_pool_; 54 scoped_refptr<base::SequencedWorkerPool> worker_pool_;
46 55
47 DISALLOW_COPY_AND_ASSIGN(NativeSupportApp); 56 DISALLOW_COPY_AND_ASSIGN(NativeSupportApp);
48 }; 57 };
49 58
50 } // namespace native_support 59 } // namespace native_support
51 60
52 MojoResult MojoMain(MojoHandle application_request) { 61 MojoResult MojoMain(MojoHandle application_request) {
53 mojo::ApplicationRunnerChromium runner( 62 native_support::NativeSupportApp native_support_app;
54 new native_support::NativeSupportApp());
55 // We need an I/O message loop, since we'll want to watch FDs. 63 // We need an I/O message loop, since we'll want to watch FDs.
56 runner.set_message_loop_type(base::MessageLoop::TYPE_IO); 64 mojo::RunApplicationOptionsChromium options(base::MessageLoop::TYPE_IO);
57 return runner.Run(application_request); 65 return mojo::RunMainApplication(application_request, &native_support_app,
66 &options);
58 } 67 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698