Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 201563005: Revert r253110: "Enable webrtc for webview." (Closed)

Created:
6 years, 9 months ago by Torne
Modified:
6 years, 9 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

Revert r253110: "Enable webrtc for webview." Temporarily disable webrtc on WebView again due to Mac host build incompatibility in libvpx. BUG=316499 R=benm@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257433

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M android_webview/lib/main/aw_main_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M build/common.gypi View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Torne
6 years, 9 months ago (2014-03-17 12:39:17 UTC) #1
benm (inactive)
lgtm
6 years, 9 months ago (2014-03-17 12:47:36 UTC) #2
Torne
The CQ bit was checked by torne@chromium.org
6 years, 9 months ago (2014-03-17 12:48:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/201563005/1
6 years, 9 months ago (2014-03-17 12:48:25 UTC) #4
Torne
Committed patchset #1 manually as r257433 (presubmit successful).
6 years, 9 months ago (2014-03-17 15:21:27 UTC) #5
michaelbai
On 2014/03/17 15:21:27, Torne wrote: > Committed patchset #1 manually as r257433 (presubmit successful). Can ...
6 years, 9 months ago (2014-03-18 15:29:55 UTC) #6
benm (inactive)
On 2014/03/18 15:29:55, michaelbai wrote: > On 2014/03/17 15:21:27, Torne wrote: > > Committed patchset ...
6 years, 9 months ago (2014-03-18 15:32:39 UTC) #7
michaelbai
6 years, 9 months ago (2014-03-18 15:36:08 UTC) #8
Message was sent while issue was closed.
On 2014/03/18 15:32:39, benm wrote:
> On 2014/03/18 15:29:55, michaelbai wrote:
> > On 2014/03/17 15:21:27, Torne wrote:
> > > Committed patchset #1 manually as r257433 (presubmit successful).
> > 
> > Can we revert it only if the host is Mac?
> 
> Sorry, I don't think so. We need to get the mac host build working.

I knew, just disable the webrtc on Mac temporarily, since currently WebRTC
doesn't build on Android anymore, it could be broken while we try to fix the
Mac's issue.

Powered by Google App Engine
This is Rietveld 408576698