Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Unified Diff: base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java

Issue 2015533005: Record the return value of NativeLibraryPreloader.loadLibrary in UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/android/java/src/org/chromium/base/library_loader/NativeLibraryPreloader.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java
diff --git a/base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java b/base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java
index a9a3141a3deb009e8ffb2579bbaabff597e3d616..f6bf867cf8dc4ecf2af90ff4d2341c2681ed8cd8 100644
--- a/base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java
+++ b/base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java
@@ -86,6 +86,11 @@ public class LibraryLoader {
// will be reported via UMA. Set once when the libraries are done loading.
private long mLibraryLoadTimeMs;
+ // The return value of NativeLibraryPreloader.loadLibrary(), which will be reported
+ // via UMA, it is initialized to the invalid value which shouldn't showup in UMA
+ // report.
+ private int mLibraryPreloaderStatus = -1;
+
/**
* Set native library preloader, if set, the NativeLibraryPreloader.loadLibrary will be invoked
* before calling System.loadLibrary, this only applies when not using the chromium linker.
@@ -282,7 +287,7 @@ public class LibraryLoader {
linker.finishLibraryLoad();
} else {
if (sLibraryPreloader != null) {
- sLibraryPreloader.loadLibrary(context);
+ mLibraryPreloaderStatus = sLibraryPreloader.loadLibrary(context);
}
// Load libraries using the system linker.
for (String library : NativeLibraries.LIBRARIES) {
@@ -383,6 +388,9 @@ public class LibraryLoader {
getLibraryLoadFromApkStatus(context),
mLibraryLoadTimeMs);
}
+ if (sLibraryPreloader != null) {
+ nativeRecordLibraryPreloaderBrowserHistogram(mLibraryPreloaderStatus);
+ }
}
// Returns the device's status for loading a library directly from the APK file.
@@ -409,6 +417,9 @@ public class LibraryLoader {
loadAtFixedAddressFailed,
mLibraryLoadTimeMs);
}
+ if (sLibraryPreloader != null) {
+ nativeRegisterLibraryPreloaderRendererHistogram(mLibraryPreloaderStatus);
+ }
}
/**
@@ -442,6 +453,10 @@ public class LibraryLoader {
int libraryLoadFromApkStatus,
long libraryLoadTime);
+ // Method called to record the return value of NativeLibraryPreloader.loadLibrary for the main
+ // browser process.
+ private native void nativeRecordLibraryPreloaderBrowserHistogram(int status);
+
// Method called to register (for later recording) statistics about the Chromium linker
// operation for a renderer process. Indicates whether the linker attempted relro sharing,
// and if it did, whether the library failed to load at a fixed address. Also records the
@@ -451,6 +466,10 @@ public class LibraryLoader {
boolean loadAtFixedAddressFailed,
long libraryLoadTime);
+ // Method called to register (for later recording) the return value of
+ // NativeLibraryPreloader.loadLibrary for a renderer process.
+ private native void nativeRegisterLibraryPreloaderRendererHistogram(int status);
+
// Get the version of the native library. This is needed so that we can check we
// have the right version before initializing the (rest of the) JNI.
private native String nativeGetVersionNumber();
« no previous file with comments | « no previous file | base/android/java/src/org/chromium/base/library_loader/NativeLibraryPreloader.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698