content/renderer/renderer_main.cc - Issue 2015533005: Record the return value of NativeLibraryPreloader.loadLibrary in UMA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/renderer_main.cc

Issue 2015533005: Record the return value of NativeLibraryPreloader.loadLibrary in UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add histogram.xml Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/android/library_loader/library_loader_hooks.cc ('K') | « base/android/library_loader/library_loader_hooks.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/renderer_main.cc

diff --git a/content/renderer/renderer_main.cc b/content/renderer/renderer_main.cc

index bfa30738c8beea8b1751f620ec0e6809a37ab198..f02b0d8c12981a4e32534455830dc6433e8f21ff 100644

--- a/content/renderer/renderer_main.cc

+++ b/content/renderer/renderer_main.cc

@@ -149,8 +149,8 @@ int RendererMain(const MainFunctionParams& parameters) {

base::StatisticsRecorder::Initialize();

#if defined(OS_ANDROID)

- // If we have a pending chromium android linker histogram, record it.

- base::android::RecordChromiumAndroidLinkerRendererHistogram();

+ // If we have a pending LibraryLoader histogram, record it.

+ base::android::RecordChromiumAndroidLibraryLoaderRendererHistogram();

Alexei Svitkine (slow) 2016/05/26 14:56:29 Not sure what "Chromium" and "Android" add to the

michaelbai 2016/05/26 19:10:36 You are right, we could have simple name here

#endif

std::unique_ptr<scheduler::RendererScheduler> renderer_scheduler(