Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2015523004: Don't explicitly initialize LayoutUnit to 0. (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
svillar, eae
CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, zoltan1, svillar, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, Manuel Rego, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't explicitly initialize LayoutUnit to 0. The default LayoutUnit() constructor sets it to 0. Explicitly passing 0 means that LayoutUnit::setValue() will be involved, which performs (in this case: very pointless) saturation checks. Committed: https://crrev.com/3e0d01bb6765429ee3d2347337e1c8a490bd1165 Cr-Commit-Position: refs/heads/master@{#396223}

Patch Set 1 #

Patch Set 2 : Go through the subdirs of core/layout/ too. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -27 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutState.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/TableLayoutAlgorithm.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/LineLayoutState.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/shapes/BoxShapeTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/line/SVGInlineFlowBox.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
mstensho (USE GERRIT)
4 years, 7 months ago (2016-05-26 11:38:31 UTC) #2
svillar
lgtm
4 years, 7 months ago (2016-05-26 14:33:26 UTC) #4
eae
LGTM
4 years, 7 months ago (2016-05-26 17:25:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015523004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015523004/20001
4 years, 7 months ago (2016-05-26 17:48:14 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-26 17:53:05 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 17:54:15 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3e0d01bb6765429ee3d2347337e1c8a490bd1165
Cr-Commit-Position: refs/heads/master@{#396223}

Powered by Google App Engine
This is Rietveld 408576698