Sort Physical Web URLs by distance

Sort Physical Web URLs by distance

When displaying Physical Web URLs, it makes the most sense
to show the nearest URLs first.  This change sorts according
to distance (even though the distance currently in place is a
placeholder)

BUG=596708
Committed: https://crrev.com/297ef9cd6d1ba95e027349a7d8ec76b8c5123dcb
Cr-Commit-Position: refs/heads/master@{#396214}

[cco3, 2016-05-25 17:47:38]

cco3@chromium.org changed reviewers:
+ mattreynolds@chromium.org

[mattreynolds, 2016-05-25 17:51:49]

lgtm

[cco3, 2016-05-25 17:52:23]

cco3@chromium.org changed reviewers:
+ nyquist@chromium.org

[nyquist, 2016-05-25 20:26:35]

https://codereview.chromium.org/2015523003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java
(right):

https://codereview.chromium.org/2015523003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java:252:
Collections.sort(urlInfos, new Comparator<UrlInfo>() {
Could you add a test to ensure that sorting is correct?

I think it'd be helpful also then to ensure that maybe you have three items, and
that they're added in a different order than their distance.

[cco3, 2016-05-25 22:00:51]

https://codereview.chromium.org/2015523003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java
(right):

https://codereview.chromium.org/2015523003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java:252:
Collections.sort(urlInfos, new Comparator<UrlInfo>() {
On 2016/05/25 20:26:34, nyquist wrote:
> Could you add a test to ensure that sorting is correct?
> 
> I think it'd be helpful also then to ensure that maybe you have three items,
and
> that they're added in a different order than their distance.

Done.

[nyquist, 2016-05-25 23:22:37]

lgtm

[cco3, 2016-05-25 23:26:31]

The CQ bit was checked by cco3@chromium.org

[cco3, 2016-05-25 23:26:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
mattreynolds@chromium.org
Link to the patchset: https://codereview.chromium.org/2015523003/#ps40001
(title: "Add test for sorting")

[commit-bot: I haz the power, 2016-05-25 23:27:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2015523003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2015523003/40001

[commit-bot: I haz the power, 2016-05-26 00:21:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-26 00:21:39]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[cco3, 2016-05-26 00:26:14]

The CQ bit was checked by cco3@chromium.org

[cco3, 2016-05-26 00:26:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
nyquist@chromium.org, mattreynolds@chromium.org
Link to the patchset: https://codereview.chromium.org/2015523003/#ps60001
(title: "Remove dead store")

[commit-bot: I haz the power, 2016-05-26 00:26:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2015523003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2015523003/60001

[commit-bot: I haz the power, 2016-05-26 02:24:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-26 02:24:58]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[cco3, 2016-05-26 16:42:29]

The CQ bit was checked by cco3@chromium.org

[cco3, 2016-05-26 16:42:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
nyquist@chromium.org, mattreynolds@chromium.org
Link to the patchset: https://codereview.chromium.org/2015523003/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-05-26 16:42:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2015523003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2015523003/80001

[commit-bot: I haz the power, 2016-05-26 17:20:24]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-26 17:22:14]

Description was changed from

==========
Sort Physical Web URLs by distance

When displaying Physical Web URLs, it makes the most sense
to show the nearest URLs first.  This change sorts according
to distance (even though the distance currently in place is a
placeholder)

BUG=596708
==========

to

==========
Sort Physical Web URLs by distance

When displaying Physical Web URLs, it makes the most sense
to show the nearest URLs first.  This change sorts according
to distance (even though the distance currently in place is a
placeholder)

BUG=596708

Committed: https://crrev.com/297ef9cd6d1ba95e027349a7d8ec76b8c5123dcb
Cr-Commit-Position: refs/heads/master@{#396214}
==========

[commit-bot: I haz the power, 2016-05-26 17:22:15]

Patchset 5 (id:??) landed as
https://crrev.com/297ef9cd6d1ba95e027349a7d8ec76b8c5123dcb
Cr-Commit-Position: refs/heads/master@{#396214}