Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2015513006: Make linked-list non-circular. (Closed)

Created:
4 years, 7 months ago by floitsch
Modified:
4 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make linked-list non-circular. This bug was introduced when making the collection library strong-mode clean. Fixes #26522 BUG= http://dartbug.com/26522 R=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/e1bf3506d11de02d1bbc505a40ec7553b6e634c7

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -3 lines) Patch
M sdk/lib/collection/linked_list.dart View 2 chunks +3 lines, -3 lines 1 comment Download
M tests/lib/collection/linked_list_test.dart View 2 chunks +51 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
floitsch
4 years, 7 months ago (2016-05-26 15:00:58 UTC) #2
Lasse Reichstein Nielsen
https://codereview.chromium.org/2015513006/diff/1/sdk/lib/collection/linked_list.dart File sdk/lib/collection/linked_list.dart (right): https://codereview.chromium.org/2015513006/diff/1/sdk/lib/collection/linked_list.dart#newcode261 sdk/lib/collection/linked_list.dart:261: * Return the successor of this element in its ...
4 years, 7 months ago (2016-05-26 15:24:10 UTC) #3
Lasse Reichstein Nielsen
lgtm
4 years, 7 months ago (2016-05-26 15:24:15 UTC) #4
floitsch
4 years, 6 months ago (2016-06-01 12:19:44 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
e1bf3506d11de02d1bbc505a40ec7553b6e634c7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698