Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2015513005: Tweak _checkPrimitiveType (Closed)

Created:
4 years, 7 months ago by sra1
Modified:
4 years, 7 months ago
Reviewers:
vsm, Leaf
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Tweak _checkPrimitiveType V8 does better with typeof x == 'string' TBR=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/99ebc6db41f5b7e13ff33c4b0feddc9f35d2f226

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -28 lines) Patch
M lib/runtime/dart_sdk.js View 1 chunk +13 lines, -16 lines 0 comments Download
M tool/input_sdk/private/ddc_runtime/rtti.dart View 1 chunk +25 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
sra1
Committed patchset #1 (id:1) manually as 99ebc6db41f5b7e13ff33c4b0feddc9f35d2f226 (presubmit successful).
4 years, 7 months ago (2016-05-26 03:23:54 UTC) #4
Leaf
4 years, 7 months ago (2016-05-26 17:01:57 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698