Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2015513003: Optimize more megamorphic dispatch sites (Closed)

Created:
4 years, 7 months ago by Brian Wilkerson
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -110 lines) Patch
M pkg/analyzer/lib/instrumentation/instrumentation.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/context/cache.dart View 7 chunks +38 lines, -12 lines 2 comments Download
M pkg/analyzer/lib/src/context/source.dart View 9 chunks +4 lines, -65 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/type.dart View 3 chunks +6 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/dart/resolver/inheritance_manager.dart View 2 chunks +16 lines, -13 lines 0 comments Download
M pkg/analyzer/lib/src/dart/resolver/scope.dart View 3 chunks +16 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 2 chunks +8 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/task/driver.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/context/cache_test.dart View 9 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
4 years, 7 months ago (2016-05-25 17:40:16 UTC) #2
scheglov
lgtm :-( https://codereview.chromium.org/2015513003/diff/1/pkg/analyzer/lib/src/context/cache.dart File pkg/analyzer/lib/src/context/cache.dart (right): https://codereview.chromium.org/2015513003/diff/1/pkg/analyzer/lib/src/context/cache.dart#newcode738 pkg/analyzer/lib/src/context/cache.dart:738: for (int j = 0; j < ...
4 years, 7 months ago (2016-05-25 17:44:46 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2015513003/diff/1/pkg/analyzer/lib/src/context/cache.dart File pkg/analyzer/lib/src/context/cache.dart (right): https://codereview.chromium.org/2015513003/diff/1/pkg/analyzer/lib/src/context/cache.dart#newcode738 pkg/analyzer/lib/src/context/cache.dart:738: for (int j = 0; j < cacheLength; j++) ...
4 years, 7 months ago (2016-05-25 17:48:42 UTC) #4
Brian Wilkerson
4 years, 7 months ago (2016-05-25 17:49:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a3ed9fe5698396e0e85e61675f96eb6da707b088 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698