Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 2015513002: [runtime] Ensure that all elements kind transitions are chained to the root map. (Closed)

Created:
4 years, 7 months ago by Igor Sheludko
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Ensure that all elements kind transitions are chained to the root map. This CL also updates the elements kind transition lookup logic: 1) First we go back to the root map, 2) Follow elements kind transitions, 3) Replay the property transitions. BUG=v8:5009 LOG=Y TBR=bmeurer@chromium.org Committed: https://crrev.com/9fa206e1f4a36280672a4fb144cd7f78484b3c11 Cr-Commit-Position: refs/heads/master@{#36652}

Patch Set 1 : #

Patch Set 2 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+527 lines, -100 lines) Patch
M src/compiler/access-info.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M src/ic/ic.cc View 1 1 chunk +6 lines, -5 lines 0 comments Download
M src/ic/ic-compiler.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M src/objects.h View 1 4 chunks +34 lines, -18 lines 0 comments Download
M src/objects.cc View 1 20 chunks +87 lines, -55 lines 0 comments Download
M src/objects-inl.h View 1 2 chunks +20 lines, -0 lines 0 comments Download
M test/cctest/test-field-type-tracking.cc View 12 chunks +303 lines, -13 lines 0 comments Download
A test/mjsunit/regress/regress-v8-5009.js View 1 chunk +61 lines, -0 lines 0 comments Download

Messages

Total messages: 34 (18 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015513002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015513002/100001
4 years, 6 months ago (2016-05-25 14:29:52 UTC) #8
Igor Sheludko
PTAL
4 years, 6 months ago (2016-05-25 14:30:32 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/18209) v8_linux64_avx2_rel_ng on ...
4 years, 6 months ago (2016-05-25 14:31:02 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015513002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015513002/120001
4 years, 6 months ago (2016-05-25 14:33:11 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-25 15:05:38 UTC) #16
commit-bot: I haz the power
Dry run: None
4 years, 6 months ago (2016-05-25 15:05:45 UTC) #17
fedor.indutny
Sorry for the noise, but ping ;)
4 years, 6 months ago (2016-06-01 06:35:54 UTC) #18
Toon Verwaest
lgtm
4 years, 6 months ago (2016-06-01 14:59:55 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015513002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015513002/120001
4 years, 6 months ago (2016-06-01 15:23:21 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/16304)
4 years, 6 months ago (2016-06-01 15:27:11 UTC) #23
Michael Starzinger
LGTM (rubber-stamp of "compiler", didn't look at the rest).
4 years, 6 months ago (2016-06-01 15:39:23 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015513002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015513002/120001
4 years, 6 months ago (2016-06-01 15:42:14 UTC) #28
commit-bot: I haz the power
Committed patchset #2 (id:120001)
4 years, 6 months ago (2016-06-01 15:54:28 UTC) #30
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/9fa206e1f4a36280672a4fb144cd7f78484b3c11 Cr-Commit-Position: refs/heads/master@{#36652}
4 years, 6 months ago (2016-06-01 15:55:27 UTC) #32
fedor.indutny
Thank you, Michael, Toon, Igor! May I ask you if it will be possible to ...
4 years, 6 months ago (2016-06-01 16:03:30 UTC) #33
Igor Sheludko
4 years, 6 months ago (2016-06-01 16:13:17 UTC) #34
Message was sent while issue was closed.
On 2016/06/01 16:03:30, fedor.indutny wrote:
> Thank you, Michael, Toon, Igor!
> 
> May I ask you if it will be possible to backport it to v5.0.x?

I'll back merge it once we have a Canary coverage.

Powered by Google App Engine
This is Rietveld 408576698