Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2015503003: Certificate Transparency: Ensure no observers in STHDistributor d'tor. (Closed)

Created:
4 years, 7 months ago by Eran Messeri
Modified:
4 years, 6 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Certificate Transparency: Ensure no observers in STHDistributor d'tor. Check, in the STHDistributor, that there are no observers registered. This would help enforce correct usage and lifetime management of all the observers registered with each STHDistributor instance, as there are expected to be global instances of the STHDistributor. BUG=613501 Committed: https://crrev.com/4da9bf69dbb6be6dbea51339edfbee17455eb111 Cr-Commit-Position: refs/heads/master@{#396434}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M net/cert/sth_distributor.h View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/sth_distributor_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Eran Messeri
A small change in the STHDistributor for you to review.
4 years, 7 months ago (2016-05-25 14:55:00 UTC) #3
Ryan Sleevi
lgtm
4 years, 6 months ago (2016-05-27 05:03:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015503003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015503003/1
4 years, 6 months ago (2016-05-27 07:50:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 10:05:09 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 10:07:03 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4da9bf69dbb6be6dbea51339edfbee17455eb111
Cr-Commit-Position: refs/heads/master@{#396434}

Powered by Google App Engine
This is Rietveld 408576698