Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: third_party/WebKit/Source/core/html/track/vtt/VTTRegion.idl

Issue 2015503002: Move TODO(philipj) to TODO(foolip) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 12 matching lines...) Expand all
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 // http://dev.w3.org/html5/webvtt/#the-vttregion-interface 26 // http://dev.w3.org/html5/webvtt/#the-vttregion-interface
27 27
28 [ 28 [
29 Constructor, 29 Constructor,
30 RuntimeEnabled=WebVTTRegions, 30 RuntimeEnabled=WebVTTRegions,
31 ] interface VTTRegion { 31 ] interface VTTRegion {
32 [RaisesException=Setter] attribute double width; 32 [RaisesException=Setter] attribute double width;
33 // TODO(philipj): height should be called lines. 33 // TODO(foolip): height should be called lines.
34 [RaisesException=Setter] attribute long height; 34 [RaisesException=Setter] attribute long height;
35 [RaisesException=Setter] attribute double regionAnchorX; 35 [RaisesException=Setter] attribute double regionAnchorX;
36 [RaisesException=Setter] attribute double regionAnchorY; 36 [RaisesException=Setter] attribute double regionAnchorY;
37 [RaisesException=Setter] attribute double viewportAnchorX; 37 [RaisesException=Setter] attribute double viewportAnchorX;
38 [RaisesException=Setter] attribute double viewportAnchorY; 38 [RaisesException=Setter] attribute double viewportAnchorY;
39 // TODO(philip): scroll should be of type ScrollSetting. 39 // TODO(philip): scroll should be of type ScrollSetting.
40 [RaisesException=Setter] attribute DOMString scroll; 40 [RaisesException=Setter] attribute DOMString scroll;
41 41
42 // TODO(philipj): The track/id attributes are gone from the spec: 42 // TODO(foolip): The track/id attributes are gone from the spec:
43 // https://www.w3.org/Bugs/Public/show_bug.cgi?id=24380 43 // https://www.w3.org/Bugs/Public/show_bug.cgi?id=24380
44 readonly attribute TextTrack track; 44 readonly attribute TextTrack track;
45 attribute DOMString id; 45 attribute DOMString id;
46 }; 46 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698