third_party/WebKit/LayoutTests/media/video-source-type.html - Issue 2015503002: Move TODO(philipj) to TODO(foolip)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-source-type.html

Issue 2015503002: Move TODO(philipj) to TODO(foolip) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/video-source-removed.html ('k') | third_party/WebKit/LayoutTests/media/video-source-type-params.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title> <source> @type attribute</title>	4 <title> <source> @type attribute</title>

5	5

6 <script src=media-file.js></script>	6 <script src=media-file.js></script>

7 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956	7 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

8 (Please avoid writing new tests using video-test.js) -->	8 (Please avoid writing new tests using video-test.js) -->

9 <script src=video-test.js></script>	9 <script src=video-test.js></script>

10 <script>	10 <script>

11 waitForEvent("loadstart", function () {	11 waitForEvent("loadstart", function () {

12 video = mediaElement = document.getElementsByTagName('video')[0];	12 video = mediaElement = document.getElementsByTagName('video')[0];

13 testExpected("stripExtension(relativeURL(video.currentSrc))", stripE xtension(findMediaFile("video", "content/test")));	13 testExpected("stripExtension(relativeURL(video.currentSrc))", stripE xtension(findMediaFile("video", "content/test")));

14 endTest();	14 endTest();

15 });	15 });

16 </script>	16 </script>

17 </head>	17 </head>

18 <body>	18 <body>

19 <video controls>	19 <video controls>

20 <source src=content/error.mpeg type=video/blahblah>	20 <source src=content/error.mpeg type=video/blahblah>

21 <source src=test.mp4 type=video/x-chicken-face>	21 <source src=test.mp4 type=video/x-chicken-face>

22 <source src=test.ogv type=audio/x-higglety-pigglety>	22 <source src=test.ogv type=audio/x-higglety-pigglety>

23 <source src=content/test.mp4 type=video/mp4>	23 <source src=content/test.mp4 type=video/mp4>

24 <source src=content/test.ogv type=video/ogg>	24 <source src=content/test.ogv type=video/ogg>

25 <source src=content/error2.mpeg type=video/mpeg>	25 <source src=content/error2.mpeg type=video/mpeg>

26 </video>	26 </video>

27 </body>	27 </body>

28 </html>	28 </html>

OLD	NEW