third_party/WebKit/LayoutTests/media/video-source-add-after-remove.html - Issue 2015503002: Move TODO(philipj) to TODO(foolip)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-source-add-after-remove.html

Issue 2015503002: Move TODO(philipj) to TODO(foolip) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>Add <source> after removing failed candidate</title>	4 <title>Add <source> after removing failed candidate</title>

5 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956	5 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

6 (Please avoid writing new tests using video-test.js) -->	6 (Please avoid writing new tests using video-test.js) -->

7 <script src=video-test.js></script>	7 <script src=video-test.js></script>

8 <script src=media-file.js></script>	8 <script src=media-file.js></script>

9 <script>	9 <script>

10 function error()	10 function error()

11 {	11 {

12 findMediaElement();	12 findMediaElement();

13 video.removeChild(video.firstChild);	13 video.removeChild(video.firstChild);

14 var source = document.createElement("source");	14 var source = document.createElement("source");

15 source.src = findMediaFile("video", "content/test");	15 source.src = findMediaFile("video", "content/test");

16 video.appendChild(source);	16 video.appendChild(source);

17 waitForEventAndEnd("loadedmetadata");	17 waitForEventAndEnd("loadedmetadata");

18 }	18 }

19 </script>	19 </script>

20 </head>	20 </head>

21	21

22 <body>	22 <body>

23 <video><source onerror="error()"></video>	23 <video><source onerror="error()"></video>

24 </body>	24 </body>

25 </html>	25 </html>

OLD	NEW