third_party/WebKit/LayoutTests/media/video-plays-past-end-of-test.html - Issue 2015503002: Move TODO(philipj) to TODO(foolip)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-plays-past-end-of-test.html

Issue 2015503002: Move TODO(philipj) to TODO(foolip) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <p>This test intentionally lets the video keep playing past endTest() to ensure	1 <p>This test intentionally lets the video keep playing past endTest() to ensure

2 that shutdown is clean, since DumpRenderTree used to crash in this case.</p>	2 that shutdown is clean, since DumpRenderTree used to crash in this case.</p>

3	3

4 <video autoplay id="video"></video>	4 <video autoplay id="video"></video>

5 <script src=media-file.js></script>	5 <script src=media-file.js></script>

6 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956	6 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

7 (Please avoid writing new tests using video-test.js) -->	7 (Please avoid writing new tests using video-test.js) -->

8 <script src=video-test.js></script>	8 <script src=video-test.js></script>

9 <script type="text/javascript">	9 <script type="text/javascript">

10 if (window.testRunner)	10 if (window.testRunner)

11 testRunner.dumpAsText();	11 testRunner.dumpAsText();

12 waitForEvent("playing", null, true);	12 waitForEvent("playing", null, true);

13 video.src = findMediaFile("video", "content/test");	13 video.src = findMediaFile("video", "content/test");

14 </script>	14 </script>

OLD	NEW