third_party/WebKit/LayoutTests/media/video-delay-load-event.html - Issue 2015503002: Move TODO(philipj) to TODO(foolip)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-delay-load-event.html

Issue 2015503002: Move TODO(philipj) to TODO(foolip) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/video-defaultmuted.html ('k') | third_party/WebKit/LayoutTests/media/video-display-aspect-ratio.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>delay document 'load' event test</title>	4 <title>delay document 'load' event test</title>

5 <style> video { border: 3px solid red; } </style>	5 <style> video { border: 3px solid red; } </style>

6 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956	6 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

7 (Please avoid writing new tests using video-test.js) -->	7 (Please avoid writing new tests using video-test.js) -->

8 <script src=video-test.js></script>	8 <script src=video-test.js></script>

9 <script src=media-file.js></script>	9 <script src=media-file.js></script>

10 <script>	10 <script>

11 var video;	11 var video;

12	12

13 function testMovieWithNoSource(elem)	13 function testMovieWithNoSource(elem)

14 {	14 {

15 video = elem; // Need it in a global for testExpected() to see it.	15 video = elem; // Need it in a global for testExpected() to see it.

16 consoleWrite("<em>no 'src'.</em>");	16 consoleWrite("<em>no 'src'.</em>");

(...skipping 46 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
63 testMovieWithSource(video, false, "<br><em>with 'src' attribute.</em >");	63 testMovieWithSource(video, false, "<br><em>with 'src' attribute.</em >");

64	64

65 source = document.getElementById('source-1');	65 source = document.getElementById('source-1');

66 source.src = findMediaFile("video", "content/test");	66 source.src = findMediaFile("video", "content/test");

67 testMovieWithSource(document.getElementById('video-3'), false, "<br> <em>with <source> element.</em>");	67 testMovieWithSource(document.getElementById('video-3'), false, "<br> <em>with <source> element.</em>");

68 document.getElementById('video-3').load();	68 document.getElementById('video-3').load();

69 </script>	69 </script>

70	70

71 </body>	71 </body>

72 </html>	72 </html>

OLD	NEW