third_party/WebKit/LayoutTests/media/video-currentTime-set2.html - Issue 2015503002: Move TODO(philipj) to TODO(foolip)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-currentTime-set2.html

Issue 2015503002: Move TODO(philipj) to TODO(foolip) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/video-currentTime-set.html ('k') | third_party/WebKit/LayoutTests/media/video-defaultmuted.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <video controls></video>	1 <video controls></video>

2 <script src=media-file.js></script>	2 <script src=media-file.js></script>

3 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956	3 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

4 (Please avoid writing new tests using video-test.js) -->	4 (Please avoid writing new tests using video-test.js) -->

5 <script src=video-test.js></script>	5 <script src=video-test.js></script>

6 <script>	6 <script>

7 waitForEvent('canplaythrough',	7 waitForEvent('canplaythrough',

8 function () {	8 function () {

9 testException("video.currentTime = -Infinity", '"TypeError: Failed to se t the \'currentTime\' property on \'HTMLMediaElement\': The provided double valu e is non-finite."');	9 testException("video.currentTime = -Infinity", '"TypeError: Failed to se t the \'currentTime\' property on \'HTMLMediaElement\': The provided double valu e is non-finite."');

10 testException("video.currentTime = Infinity", '"TypeError: Failed to set the \'currentTime\' property on \'HTMLMediaElement\': The provided double value is non-finite."');	10 testException("video.currentTime = Infinity", '"TypeError: Failed to set the \'currentTime\' property on \'HTMLMediaElement\': The provided double value is non-finite."');

11 testException("video.currentTime = NaN", '"TypeError: Failed to set the \'currentTime\' property on \'HTMLMediaElement\': The provided double value is n on-finite."');	11 testException("video.currentTime = NaN", '"TypeError: Failed to set the \'currentTime\' property on \'HTMLMediaElement\': The provided double value is n on-finite."');

12 video.currentTime = 1.5;	12 video.currentTime = 1.5;

13 testExpected("video.currentTime.toFixed(1)", 1.5);	13 testExpected("video.currentTime.toFixed(1)", 1.5);

14 video.play();	14 video.play();

15 video.currentTime = 3.1;	15 video.currentTime = 3.1;

16 testExpected("video.currentTime.toFixed(1)", 3.1);	16 testExpected("video.currentTime.toFixed(1)", 3.1);

17 endTest();	17 endTest();

18 });	18 });

19 video.src = findMediaFile("video", "content/test");	19 video.src = findMediaFile("video", "content/test");

20 </script>	20 </script>

OLD	NEW