third_party/WebKit/LayoutTests/media/video-currentTime-set.html - Issue 2015503002: Move TODO(philipj) to TODO(foolip)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-currentTime-set.html

Issue 2015503002: Move TODO(philipj) to TODO(foolip) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/video-currentTime-delay.html ('k') | third_party/WebKit/LayoutTests/media/video-currentTime-set2.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <body>	2 <body>

3	3

4 <video controls></video>	4 <video controls></video>

5	5

6 <p>Test that setting currentTime changes the time, and that 'ended' event is fired in a reasonable amount of time</p>	6 <p>Test that setting currentTime changes the time, and that 'ended' event is fired in a reasonable amount of time</p>

7	7

8 <script src=media-file.js></script>	8 <script src=media-file.js></script>

9 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956	9 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

10 (Please avoid writing new tests using video-test.js) -->	10 (Please avoid writing new tests using video-test.js) -->

11 <script src=video-test.js></script>	11 <script src=video-test.js></script>

12 <script>	12 <script>

13 waitForEventOnce('canplaythrough',	13 waitForEventOnce('canplaythrough',

14 function () {	14 function () {

15 waitForEventAndEnd('ended');	15 waitForEventAndEnd('ended');

16	16

17 testExpected("video.currentTime", 0);	17 testExpected("video.currentTime", 0);

18 run("video.currentTime = video.duration - 0.2");	18 run("video.currentTime = video.duration - 0.2");

19 });	19 });

20	20

21 waitForEvent('seeked',	21 waitForEvent('seeked',

22 function () {	22 function () {

23 testExpected("video.currentTime.toFixed(2)", (video.duration - 0.2).toFi xed(2));	23 testExpected("video.currentTime.toFixed(2)", (video.duration - 0.2).toFi xed(2));

24 run("video.play()");	24 run("video.play()");

25 consoleWrite("");	25 consoleWrite("");

26 });	26 });

27	27

28 video.src = findMediaFile("video", "content/test");	28 video.src = findMediaFile("video", "content/test");

29 </script>	29 </script>

30	30

31 </body>	31 </body>

32 </html>	32 </html>

OLD	NEW