third_party/WebKit/LayoutTests/media/video-controls.html - Issue 2015503002: Move TODO(philipj) to TODO(foolip)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-controls.html

Issue 2015503002: Move TODO(philipj) to TODO(foolip) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/video-capture-preview.html ('k') | third_party/WebKit/LayoutTests/media/video-controls-always-visible-when-control-hovered.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <video controls></video>	1 <video controls></video>

2 <p>Test 'controls' attribute<p>	2 <p>Test 'controls' attribute<p>

3 <script src=media-file.js></script>	3 <script src=media-file.js></script>

4 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956	4 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

5 (Please avoid writing new tests using video-test.js) -->	5 (Please avoid writing new tests using video-test.js) -->

6 <script src=video-test.js></script>	6 <script src=video-test.js></script>

7 <script>	7 <script>

8 testExpected("video.controls", null, '!=');	8 testExpected("video.controls", null, '!=');

9 waitForEvent('canplaythrough', function () {	9 waitForEvent('canplaythrough', function () {

10 testExpected("video.controls", null, '!=');	10 testExpected("video.controls", null, '!=');

11 run("video.removeAttribute('controls')");	11 run("video.removeAttribute('controls')");

12 testExpected("video.controls", false, '==');	12 testExpected("video.controls", false, '==');

13 run("video.controls = true");	13 run("video.controls = true");

14 testExpected("video.getAttribute('controls')", "");	14 testExpected("video.getAttribute('controls')", "");

15 run("video.controls = false");	15 run("video.controls = false");

16 testExpected("video.controls", false, '==');	16 testExpected("video.controls", false, '==');

17 run("video.setAttribute('controls','controls')");	17 run("video.setAttribute('controls','controls')");

18 testExpected("video.controls", null, '!=');	18 testExpected("video.controls", null, '!=');

19 endTest();	19 endTest();

20 } );	20 } );

21 video.src = findMediaFile("video", "content/test");	21 video.src = findMediaFile("video", "content/test");

22 </script>	22 </script>

OLD	NEW